1166496 - Make some additions to the webRequest API that would be useful for Adblock

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P3)

Description

[Tom S [:evilpie]]

For ABP we really want to have two additional bits of information.

1) For onBeforeRequest we want the whole chain of URLs from the current frame (or image etc.) to the top frame/window. Usually this is going to be two items. Like ['google.com', 'image.google.com/gif']

2) onHeadersReceived needs the windowId of the channel. Otherwise it's basically impossible to tell for what frame/window the headers apply.

Comment 1

[Tom S [:evilpie]]

So in onHeadersReceiver we can easily get the innerWindowID from the loadInfo of the channel. However for onBeforeRequest we get the outerWindowID. I am not quite sure which of these is usually more useful, but we really need to use the same one. I think only the innerWindowID is actually unique across different content processes.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I have a patch to attach the outer window ID to the loadinfo. That's the one we want.

We don't have a way to do 1) though.

Comment 3

[The 8472]

General question, not adblock-related: Is it possible to get information about sandboxing on web requests?

I think it would be a good policy for content blockers to treat sandboxed content differently since it leaks less browsing information and is less intrusive if the right flags are set.

Comment 4

[Andy McKay]

Bill, is this still a thing and do you have that patch from last year?

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think #2 was fixed by bug 1163861. #1 is still an issue as far as I know. I'm guessing Giorgio has some thoughts on that.

Comment 6

[Andy McKay]

Any thoughts on part 1 of comment 0 Giorgio?

Comment 7

[Giorgio Maone [:ma1]]

(In reply to Tom Schuster [:evilpie] from comment #0)
> For ABP we really want to have two additional bits of information.
> 
> 1) For onBeforeRequest we want the whole chain of URLs from the current
> frame (or image etc.) to the top frame/window. Usually this is going to be
> two items. Like ['google.com', 'image.google.com/gif']
> 

NoScript could use them too. I filed bug 1305237 to add this feature.

Comment 8

[Andy McKay]

Just cleaning, the only blocking bug remaining on this tracker, bug 1305237 already blocks noscript and abp, so this bug serves no purpose. Closing.