Closed Bug 1166552 Opened 4 years ago Closed 4 years ago

browser_newtab_reportLinkAction.js fails on timeout

Categories

(Firefox :: New Tab Page, defect)

Unspecified
All
defect
Not set
Points:
5

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
41.1 - May 25
Tracking Status
firefox40 --- fixed
firefox41 --- verified

People

(Reporter: mzhilyaev, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Whiteboard: .006)

Attachments

(3 files)

./mach mochitest-browser browser/base/content/test/newtab/browser_newtab_reportLinkAction.js 

hangs on MacOS, while displaying a unicorn picture "New tab got an update!".
This probably passes when all the other mochitests are run and cause the onboarding to have already been shown.

We should do the same for the update pref:

http://mxr.mozilla.org/mozilla-central/source/testing/profiles/prefs_general.js#192
Attached patch v1Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8607993 - Flags: review?(adw)
Attachment #8607993 - Flags: review?(adw) → review+
Blocks: 1138818
https://hg.mozilla.org/mozilla-central/rev/c20e5947d8dd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Blocks: 1140185
Verified on most recent gecko-dev build. the test does not hang/fail anymore
output of git log is attached below:

>>
~/gecko-dev$ git lg
*   a9bac08 - (HEAD, origin/master, origin/HEAD, master) merge mozilla-inbound to mozilla-central a=merge (8 hours ago) <Carsten "Tomcat" Book>
|\  
| * 838880e - Bug 1163497. Part 5 - remove unused functions. r=roc. (16 hours ago) <JW Wang>
| * 5db825a - Bug 1163497. Part 4 - move output stream code from MediaDecoder::AddOutputStream() to DecodedStream::Connect(). r=roc. (16 hours ago) <JW Wa
| * 5871f0d - Bug 1163497. Part 3 - move stream connection code from MediaDecoder::RecreateDecodedStream() to DecodedStream::RecreateData(). r=roc. (16 ho
| * 4db24fa - Bug 1163497. Part 2 - Remove MediaDecoder::DestroyDecodedStream(). r=roc. (2 weeks ago) <JW Wang>
| * 6166489 - Bug 1163497. Part 1 - remove MediaDecoder::ConnectDecodedStreamToOutputStream(). r=roc. (2 weeks ago) <JW Wang>
| *   9a4f92d - Merge m-c to m-i (16 hours ago) <Phil Ringnalda>
Status: RESOLVED → VERIFIED
Comment on attachment 8610029 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment: See bug 1140185 comment 11
Attachment #8610029 - Flags: approval-mozilla-aurora?
http://hg.mozilla.org/releases/mozilla-aurora/rev/303f9fa801b6
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8610029 [details] [diff] [review]
for aurora (Mardak will land)

approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610029 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.