Use darker toolbar icons on Windows 10

VERIFIED FIXED in Firefox 40

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: ntim, Assigned: jaws)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 41
Unspecified
Windows 10
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox40+ verified, firefox41 verified, firefox42 verified)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

2 years ago
The titlebar on Windows 10 is now fully light gray, darkening the icons would increase the contrast, and would as well improve consistency with other apps, which have a dark icon style.
(Reporter)

Comment 1

2 years ago
Using the Yosemite icon color is a good idea, since Yosemite apps have a very similar icon style to Windows apps (thin lines, black color).

Philipp, thoughts
Flags: needinfo?(philipp)
(Reporter)

Comment 2

2 years ago
(In reply to Tim Nguyen [:ntim] (limited availability) from comment #1)
> Using the Yosemite icon color is a good idea, since Yosemite apps have a
> very similar icon style to Windows apps (thin lines, black color).
> 
> Philipp, thoughts

thoughts ?*
Adding Stephen who is currently working on the theme.
We should really make a decision on that before sending Ben off to scale all the icons.
Flags: needinfo?(philipp) → needinfo?(shorlander)
I've noticed this too. Kinda tough on the eyes because it's low-contrast. Spartan's icons are indeed a bit darker (#616161 vs our #797c80), but I suspect it's effectively a bit worse because their icons are just outlines, whereas ours are solid.
We're currently using the Toolbar.png designed for Windows 8, and that one is lighter than all other variants.
We are still working out the final design, but it will definitely be darker.
Flags: needinfo?(shorlander)
needinfo for the final images
Blocks: 1158143
Flags: needinfo?(shorlander)
OS: Unspecified → Windows 10
Summary: Consider darkening the toolbar icons on Windows 10 → Use darker toolbar icons on Windows 10

Updated

2 years ago
Priority: -- → P1
Created attachment 8626621 [details]
Toolbar-Win10.png
Flags: needinfo?(shorlander)
Created attachment 8626622 [details]
Toolbar-Win10@2x.png
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Created attachment 8626644 [details] [diff] [review]
Patch
Attachment #8626644 - Flags: review?(dao)
Comment on attachment 8626644 [details] [diff] [review]
Patch

>+% override chrome://browser/skin/Toolbar.png                          chrome://browser/skin/Toolbar-XP.png                              os=WINNT osversion<6
> % override chrome://browser/skin/Toolbar.png                          chrome://browser/skin/Toolbar-aero.png                            os=WINNT osversion=6
> % override chrome://browser/skin/Toolbar.png                          chrome://browser/skin/Toolbar-aero.png                            os=WINNT osversion=6.1
>-% override chrome://browser/skin/Toolbar.png                          chrome://browser/skin/Toolbar-XP.png                              os=WINNT osversion<6
>+% override chrome://browser/skin/Toolbar.png                          chrome://browser/skin/Toolbar-win8.png                            os=WINNT osversion=6.2
>+% override chrome://browser/skin/Toolbar.png                          chrome://browser/skin/Toolbar-win8.png                            os=WINNT osversion=6.3

These were sorted by file name. Sorting by version is fine by me too.

> % override chrome://browser/skin/loop/toolbar.png                     chrome://browser/skin/loop/toolbar-aero.png                       os=WINNT osversion=6
> % override chrome://browser/skin/loop/toolbar.png                     chrome://browser/skin/loop/toolbar-aero.png                       os=WINNT osversion=6.1
> % override chrome://browser/skin/loop/toolbar.png                     chrome://browser/skin/loop/toolbar-XP.png                         os=WINNT osversion<6
> % override chrome://browser/skin/loop/toolbar@2x.png                  chrome://browser/skin/loop/toolbar-aero@2x.png                    os=WINNT osversion=6
> % override chrome://browser/skin/loop/toolbar@2x.png                  chrome://browser/skin/loop/toolbar-aero@2x.png                    os=WINNT osversion=6.1
> % override chrome://browser/skin/loop/toolbar@2x.png                  chrome://browser/skin/loop/toolbar-XP@2x.png                      os=WINNT osversion<6

... but then you should make the same change here.
Attachment #8626644 - Flags: review?(dao) → review+

Comment 12

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/a4a21d308c35
https://hg.mozilla.org/mozilla-central/rev/a4a21d308c35
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Depends on: 1178307
[Tracking Requested - why for this release]: We should track this as Firefox 40 will be the first release with better Windows 10 design and the darker graphics are a large part of it.

I will request uplift for this patch when bug 1178307 is fixed and can be uplifted as well.
status-firefox40: --- → affected
tracking-firefox40: --- → ?
Flags: qe-verify+
Verified fixed on Nightly 42.0a1 (2015-06-30) and Aurora 41.0a2 (2015-07-06), using Windows 10 Pro x64 (Insider Preview Build 10158).

The buttons from the toolbar are now darker, with the exception of the Hello button, which will be treated in Bug 1178307.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
status-firefox42: --- → verified
Flags: qe-verify+

Comment 16

2 years ago
Tracking for 40 because affected, awaiting potential uplift.
tracking-firefox40: ? → +
Jared, could you fill the uplift requests for bug 1178307 and this one ? (so that we are ready when the second lands).
Flags: needinfo?(jaws)
Created attachment 8634235 [details] [diff] [review]
Patch for Beta40

Approval Request Comment
[Feature/regressing bug #]: Windows 10 icons
[User impact if declined]: Windows 10 will have toolbar icons that don't have enough contrast
[Describe test coverage new/current, TreeHerder]: simple icon replacement
[Risks and why]: none
[String/UUID change made/needed]: none
Flags: needinfo?(jaws)
Attachment #8634235 - Flags: approval-mozilla-beta?
Attachment #8634235 - Attachment is obsolete: true
Attachment #8634235 - Flags: approval-mozilla-beta?
Created attachment 8634236 [details] [diff] [review]
Patch for Beta40

Approval Request Comment
[Feature/regressing bug #]: Windows 10 icons
[User impact if declined]: Windows 10 will have toolbar icons that don't have enough contrast
[Describe test coverage new/current, TreeHerder]: simple icon replacement
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8634236 - Flags: approval-mozilla-beta?
Comment on attachment 8634236 [details] [diff] [review]
Patch for Beta40

We want a great version of fx for windows 10, taking it.
Attachment #8634236 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/2a4f3dedeccf
status-firefox40: affected → fixed
Flags: qe-verify+
Verified as fixed on Firefox 40 beta 6, build ID: 20150720220238 using the latest build of Windows 10 64bit.
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.