1166978 - Dual user messaging around add-on validation is confusing

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[krupa raj[:krupa]]

Attachment: multi.xpi

steps to reproduce:
1. Load https://addons.allizom.org/en-US/developers/addon/submit/2
2. Upload the attached test add-on as an unlisted add-on
3. Notice the user messaging after the add-on validation completes.

observed behavior:
Notice that there are two conflicting and possibly confusing messages to the user. At the top, we say "Your add-on passed validation with no errors and 167 messages."

And below that section, we say "Your submission didn't pass automatic validation. Check the checkbox to submit for manual review."

It may not be obvious to the add-on developer that the user messages are referring to two different types of validation. We should rephrase these user-messages to be less confusing.

screenshot: https://www.dropbox.com/s/2dqjkorpf2gjurg/Screenshot%202015-05-20%2016.21.18.png?dl=0

Comment 1

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-05-21 at 13.55.11.png

How about "Your add-on was validated with no errors and 2 messages."?

Comment 2

[Mathieu Agopian [:magopian]]

PR: https://bugzilla.mozilla.org/show_bug.cgi?id=1166978

Comment 3

[Mathieu Agopian [:magopian]]

Oops sorry: PR: https://github.com/mozilla/olympia/pull/565

Comment 4

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/1801217b2e07d0f3d0bc8159ed098abb8b39df3c

Comment 5

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-05-21 at 20.05.54.png

Krupa asked for a rewording

Comment 6

[Mathieu Agopian [:magopian]]

New PR: https://github.com/mozilla/olympia/pull/568

Comment 7

[Mathieu Agopian [:magopian]]

Fixed (again) in https://github.com/mozilla/olympia/commit/d01b74f180758a30ba953b61a571d809a12a0dce

Comment 8

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on AMO-stage FF38(Win 7)
Postfix screenshot: http://screencast.com/t/6iUaZaJSp
Closing bug.