1167090 - Timestamps on files (e.g. camera pictures) are incorrect when read over MTP

Status: RESOLVED FIXED

(Firefox OS Graveyard :: MTP/UMS, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue seen on Mac

Using the latest private build from https://tools.taskcluster.net/index/artifacts/#gecko.v1.mozilla-central.revision.linux.2f6ea66057fe37794d7fc061407495cdcece5443.aries/gecko.v1.mozilla-central.revision.linux.2f6ea66057fe37794d7fc061407495cdcece5443.aries

SD Card is set as the default internal storage. I took some pictures first using internal and then switched to SD card.

STR:
1. Open Camera and take some picture
2. Open USB storage and move the pictures to my desktop (Mac)
3. See attached screenshot

Comment 1

[Marcia Knous [:marcia]]

[Blocking Requested - why for this release]: Blocking because we should show the correct date for each picture taken.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

It is because the current time on the phone is changing.

Comment 4

[:gerard-majax]

System date is good. It's MTP that is getting crazy.

Comment 7

[Daniel Holbert [:dholbert]]

This affects all files (and folders) as far as I can tell -- not just camera pictures.

e.g. with my Aries device mounted via MTP, I just created a new folder on it. The brand-new folder's "last modified" date is Jul 4 1993.  Several minutes later I created another new folder; that one is displayed with "last modified" Jul 6 1993. Several minutes later, a new folder ended up with "last modified" Jul 7 1993.

So they seem to be monotonically increasing, but way faster than real-world time.

I wonder if we're somehow mixing up the date vs. the time, somewhere in our MTP code, or something like that...

Comment 9

[Dave Hylands [:dhylands]]

This bug affects all MTP implementations and is not specific to Aries.

Comment 10

[Dave Hylands [:dhylands]]

Attachment: bug-1167090-mtp-time.patch

Comment 11

[Alphan Chen [:alchen]]

Comment on attachment 8626408 [details] [diff] [review]
bug-1167090-mtp-time.patch

Review of attachment 8626408 [details] [diff] [review]:
-----------------------------------------------------------------

No problem.

Comment 12

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/b2g-inbound/rev/98f46ff59f1f

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98f46ff59f1f