Unlisted addons that didn't complete step 3 should be seen as incomplete

VERIFIED FIXED in 2015-05

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: magopian, Assigned: magopian)

Tracking

unspecified
2015-05

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
An unlisted addon that is submitted on step 2 has its review queue automatically chosen (or is automatically reviewed if it passed validation).

However, the current way to detect that an addon is incomplete is to check if it's status is STATUS_NULL.

We should instead check if there are still SubmitSteps for this addon.
(Assignee)

Comment 1

3 years ago
PR: https://github.com/mozilla/olympia/pull/567
Assignee: nobody → mathieu
(Assignee)

Comment 2

3 years ago
Fixed in https://github.com/mozilla/olympia/commit/7fdd47153c1b3f723fd2d6db9ded8425a57e7216
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
Created attachment 8609083 [details]
incomplete add-on.png

I still see this issue on stage. I thought we cherry-picked this fix?
Flags: needinfo?(mathieu)
(Assignee)

Comment 4

3 years ago
The unlist add-on is seen as incomplete in the list of submissions, and clicking on it will take you back to the missing step, but this last step (step #3 for unlisted addons) is kind of optional (it's not, but the name and summary that we ask for is already known from the install.rdf in most cases). Also, it's not preventing us from reviewing it.

So while it's not "complete" for the developer, it can still be reviewed without any issue, and accepted/signed.

Because of technical constraints, it's difficult to do any better at this point.
Flags: needinfo?(mathieu)

Comment 5

3 years ago
Verified as fixed in MP-stage on FF38(WIn 7)
Postfix screencast: http://screencast.com/t/s99iaV6VyaYy
Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.