1167185 - Unlisted addons that didn't complete step 3 should be seen as incomplete

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Mathieu Agopian [:magopian]]

An unlisted addon that is submitted on step 2 has its review queue automatically chosen (or is automatically reviewed if it passed validation).

However, the current way to detect that an addon is incomplete is to check if it's status is STATUS_NULL.

We should instead check if there are still SubmitSteps for this addon.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/567

Comment 2

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/7fdd47153c1b3f723fd2d6db9ded8425a57e7216

Comment 3

[krupa raj[:krupa]]

Attachment: incomplete add-on.png

I still see this issue on stage. I thought we cherry-picked this fix?

Comment 4

[Mathieu Agopian [:magopian]]

The unlist add-on is seen as incomplete in the list of submissions, and clicking on it will take you back to the missing step, but this last step (step #3 for unlisted addons) is kind of optional (it's not, but the name and summary that we ask for is already known from the install.rdf in most cases). Also, it's not preventing us from reviewing it.

So while it's not "complete" for the developer, it can still be reviewed without any issue, and accepted/signed.

Because of technical constraints, it's difficult to do any better at this point.

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

Verified as fixed in MP-stage on FF38(WIn 7)
Postfix screencast: http://screencast.com/t/s99iaV6VyaYy
Closing bug.