1167516 - Enable marionette text_selection_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

bug 1167277 has removed text_selection_test.js, we should figure why it fails and enable it again.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] cctuan:1167516 > mozilla-b2g:master

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

  1) Text selection > without lockscreen check functionality short cut test:
     
  Crash detected but error running stackwalk
  
  

  2) Text selection > without lockscreen selection carets bug bug1120358 : Positions of selection carets should be updated correctly while scrolling (so far on device only):
     
  Crash detected but error running stackwalk

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

when I try to run 
"make test-integration-test TEST_FILES=apps/system/test/marionette/text_selection_test.js VERBOSE=1" and disable all the tests except 'short cut test' , and also remove most of code except 
"var caretPositionOfSourceInput =
          fakeTextselectionApp.FunctionalitySourceInput
          .selectionHelper.selectionLocationHelper();"
and I also put return; right after "var rangeCount = this.rangeCount();" in selectionLocationHelper

I found the output like below,
{"level":"error","stack":[],"message":"Error in parsing value for 'bottom'.  Declaration dropped.","filename":"chrome://b2g/content/shell.html","lineNumber":0}
        1) short cut test
{ [Error: Not connected. To write data you must call connect first.]
and then 
"Crash detected but error running stackwalk"

Hi Morris,
any idea ...?

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

It looks like bug 1149618 has removed SpecialPowers from marionette and breaks some tests. 
Filing bug 1168326 to enable them.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8609221 [details] [review]
[gaia] cctuan:1167516 > mozilla-b2g:master

Hi Jeremy,

I've disabled the two failing tests and enable text_selection marionette again, and you can see the tests which are related to my modification on tbpl are green.

Could you check? Thanks.

Comment 6

[Jeremy Chen ([e-mail])]

Comment on attachment 8609221 [details] [review]
[gaia] cctuan:1167516 > mozilla-b2g:master

LGTM :)

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

merge to master: https://github.com/mozilla-b2g/gaia/commit/05380df3158fa39e1dde1687c0bf11a71f8c6868