Closed
Bug 1167890
Opened 9 years ago
Closed 9 years ago
Deny DOM fullscreen in fullscreen mode won't exit DOM fullscreen
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
3.85 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Step to reproduce: 1. Enter fullscreen mode 2. Enter DOM fullscreen 3. Click Deny Expected result: Exit DOM fullscreen but stay on fullscreen mode Actual result: * In e10s window, DOM fullscreen is not exited * In non-e10s window, DOM fullscreen is exited, but the chrome controls is not displayed normaly This is a regression of bug 1053413.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → quanxunzhen
Assignee | ||
Comment 1•9 years ago
|
||
Note that, the event listener set in this patch depends on the patch in bug 1167607. Without that patch, this patch probably won't work.
Attachment #8609909 -
Flags: review?(dao)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8609909 [details] [diff] [review] patch Review of attachment 8609909 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser-fullScreen.js @@ +179,5 @@ > this._fullScrToggler.hidden = true; > }, > > + exitDomFullscreen: function () { > + }, This useless definition has been removed locally.
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8609909 [details] [diff] [review] patch Review of attachment 8609909 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser-fullScreen.js @@ +14,5 @@ > > init: function() { > // called when we go into full screen, even if initiated by a web page script > window.addEventListener("fullscreen", this, true); > + window.addEventListener("MozDOMFullscreen:Exited", this, true); This should probably be changed to > window.addEventListener("MozDOMFullscreen:Exited", this, > /* useCapture */ true, > /* wantsUntrusted */ false);
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8609909 -
Attachment is obsolete: true
Attachment #8609909 -
Flags: review?(dao)
Attachment #8611600 -
Flags: review?(dao)
Updated•9 years ago
|
Attachment #8611600 -
Flags: review?(dao) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df24a0f5a0bc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•