1167890 - Deny DOM fullscreen in fullscreen mode won't exit DOM fullscreen

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Step to reproduce:
1. Enter fullscreen mode
2. Enter DOM fullscreen
3. Click Deny

Expected result:
Exit DOM fullscreen but stay on fullscreen mode

Actual result:
* In e10s window, DOM fullscreen is not exited
* In non-e10s window, DOM fullscreen is exited, but the chrome controls is not displayed normaly

This is a regression of bug 1053413.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Note that, the event listener set in this patch depends on the patch in bug 1167607. Without that patch, this patch probably won't work.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8609909 [details] [diff] [review]
patch

Review of attachment 8609909 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-fullScreen.js
@@ +179,5 @@
>      this._fullScrToggler.hidden = true;
>    },
>  
> +  exitDomFullscreen: function () {
> +  },

This useless definition has been removed locally.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8609909 [details] [diff] [review]
patch

Review of attachment 8609909 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-fullScreen.js
@@ +14,5 @@
>  
>    init: function() {
>      // called when we go into full screen, even if initiated by a web page script
>      window.addEventListener("fullscreen", this, true);
> +    window.addEventListener("MozDOMFullscreen:Exited", this, true);

This should probably be changed to
> window.addEventListener("MozDOMFullscreen:Exited", this,
>                         /* useCapture */ true,
>                         /* wantsUntrusted */ false);

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df24a0f5a0bc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df24a0f5a0bc