1168056 - Data connection status in statusbar is inconsistent

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[:gerard-majax]

Reproduced for a while at least on Z3 and Z3c.

STR:
 - enable data
 - move to somewhere without proper network

Expected: data connection status in statusbar is synced with utility tray icon.

Actual: utility tray icon reflects the proper status but the statusbar is not.

Attached is a screenshot exposing the discrepancy. After some minutes statusbar reflected the proper state.

Comment 1

[:gerard-majax]

Attachment: 2015-05-25-11-29-10.png

Comment 2

[:gerard-majax]

Guillaume, any thought on this one? It really reminds me of bug 1144623, and it looks like we might have a pattern here again :)

Comment 3

[Dale Harvey (:daleharvey)]

Alberto has been talking about refactoring the statusbar, so pinging him since if his refactor goes ahead it may fix this

Comment 4

[Alberto Pastor [:albertopq]]

I have the impression that the update() method on each icon is currently not being called properly, since with my patch I saw some unit tests failing that should be failing right now as well... That said, I didn't investigate the root cause, so might not fix it. I'll take a look in that case.

So Alex, would you mind to test the patch in bug 1168061?

Thanks!

Comment 5

[:gerard-majax]

I can test, but I'm pretty sure older branches are impacted as well, so we should probably not rely on your work to fix it properly everywhere.

Comment 6

[Gregor Wagner [:gwagner]]

Maybe related to bug 1154965?

Comment 7

[:gerard-majax]

So I've updated one of my Z3 Compact to master with the patch from bug 1168061 applied, and I'm seeing spurious behavior of the statusbar on the clock: it gets displayed 3, sometimes 4 times.

Comment 8

[:gerard-majax]

Looks like it gets duplicated each time I unlock my device from lockscreen.

Comment 9

[:gerard-majax]

Attachment: 2015-05-27-13-36-52.png

Comment 10

[Guillaume Marty [:gmarty]]

QA, can we get a branch check on that bug?

Comment 11

[Alberto Pastor [:albertopq]]

(In reply to Alexandre LISSY :gerard-majax from comment #8)
> Looks like it gets duplicated each time I unlock my device from lockscreen.

That should be fixed now.

Comment 12

[Guillaume Marty [:gmarty]]

I don't have a SIM card with data, so I can't really check that bug.
I had a look at the code though and couldn't find any significant difference between the quick settings and the status bar.

When we know which branches are affected, we'll know more about where to look.

Comment 13

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression

Master is the only branch affected. Testing done: With 3 devices on respectively master[1], 2.2[2] and 2.1[3]:
1. Activate cell data and stay on utility tray
2. Walk down to the basement

Results: As long as you go down, you see 2.2 and 2.1 switching to Edge on both places. On master, only the utility tray is updated, the status bar keeps displaying H+. 



[1] Build ID               20150530160205
Gaia Revision          e6dc0f4c583407a4a52a66ce7cb11f058302a762
Gaia Date              2015-05-29 17:20:26
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f8d21278244b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150601.030610
Firmware Date          Mon Jun  1 03:06:23 EDT 2015
Bootloader             L1TC000118D0


[2] Build ID               20150531162502
Gaia Revision          b4582cc394e0919623263997c0cdb0b4751a1403
Gaia Date              2015-05-31 11:06:34
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/78d8b0a4303d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150531.195816
Firmware Date          Sun May 31 19:58:28 EDT 2015
Bootloader             L1TC000118D0

[3] Build ID               20150506161202
Gaia Revision          b4a03b7ee61de5a479b3cf0916f47e91a43b0f50
Gaia Date              2015-04-30 21:31:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4493015380ab
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20141120.194707
Firmware Date          Thu Nov 20 19:47:17 EST 2014
Bootloader             L1TC00011880

Comment 14

[Alberto Pastor [:albertopq]]

Johan, could you please attach the logcat when applying this patch? -> https://github.com/albertopq/gaia/tree/1168056-data-signal

Thanks!

Comment 15

[Johan Lorenzo [:jlorenzo]]

Attachment: logcat with extra debug traces

There you go.

Comment 16

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1168056-data-signal > mozilla-b2g:master

Comment 17

[Johan Lorenzo [:jlorenzo]]

Attachment: logcat with extra debug traces (on top of cf14d94)

Like asked on IRC, here's another logcat with the extra debug info you added.

Comment 18

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8613552 [details] [review]
[gaia] albertopq:1168056-data-signal > mozilla-b2g:master

With the latest revision of the patch:
* From H+ to Edge: Okay
* From Edge to no cell coverage: Not okay, the edge icon is still displayed in the status bar, even though it has disappeared in the utility tray.

Comment 19

[Alberto Pastor [:albertopq]]

Is this still happening? I haven't seen this yet while dogfooding

Comment 20

[Johan Lorenzo [:jlorenzo]]

Yes, it is. I went to the basement with an Aries, it switched from H+ to no signal on the utility tray, but the status bar remained on H+.

Build ID               20150630002527
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/aad95360a002
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150619.015544
Firmware Date          Fri Jun 19 01:55:53 UTC 2015
Bootloader             s1

Comment 21

[Alberto Pastor [:albertopq]]

I'm still unable to repro this. Etienne, is ok with you pair with Johan to get this fixed? Thanks!

Comment 22

[:gerard-majax]

I'm still seeing this too on recent master builds ...

Comment 23

[Alberto Pastor [:albertopq]]

My guess is that depends on the information the carrier is sending. Let's see if Etienne can take it a look or I'll try to send you a patch for dumping all the carrier info in order to simulate the error.

Thanks!

Comment 24

[:gerard-majax]

(In reply to Alberto Pastor [:albertopq] from comment #23)
> My guess is that depends on the information the carrier is sending. Let's
> see if Etienne can take it a look or I'll try to send you a patch for
> dumping all the carrier info in order to simulate the error.
> 
> Thanks!

I don't get your point. The information is sent, one way or another, but both notification tray and statusbar should receive it, they do not live on different devices/places ?

We are not talking about small transient mismatch, but long-standing mismatches.

Comment 25

[Alberto Pastor [:albertopq]]

We are doing some checks on the statusbar [1] that we don't in the quick settings [2]. So the data.type can be 3G, but we don't display it in the statusbar if data.connected !== true (which happens in roaming, for example). I want to make sure what's the exact information we receive in that datachange when the issue occurs. The issue might be with the quick settings and not the statusbar. Thanks

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/signal_icon.js#L56
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/quick_settings.js#L160

Comment 26

[:gerard-majax]

Makes sense, thanks for the explanation.

Comment 27

[Etienne Segonzac (:etienne)]

Taking a look...

Comment 28

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1168056 > mozilla-b2g:master

Comment 29

[Etienne Segonzac (:etienne)]

Comment on attachment 8637909 [details] [review]
[gaia] etiennesegonzac:bug-1168056 > mozilla-b2g:master

Took me ~10 back and forth to the basement :)

Comment 30

[:gerard-majax]

Oooh ... I always saw those TypeError and it never occurred to me :(

Comment 31

[Alberto Pastor [:albertopq]]

Comment on attachment 8637909 [details] [review]
[gaia] etiennesegonzac:bug-1168056 > mozilla-b2g:master

Thanks for taking this!

Comment 32

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/7195646022652e6fbc1b5e12486a8072274b4b09

Comment 33

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified as fixed on Aries 2.5 and 2.6. I observed three states using AT&T SIM:
1. Extreme low signal - Status bar shows signal icon in searching animation, and utility tray shows the square icon with two angles missing (same as attachment 8610047 [details])
2. Low signal - Status bar shows E alongside signal icon, and utility tray shows E
3. Normal signal - Status bar shows H alongside signal icon, and utility tray shows H

Device: Aries 2.6
BuildID: 20151201154446
Gaia: 59c8605876736b22acaaed25be00008e452149cb
Gecko: 974fe614d5299159dc16d98d97d76af653158d29
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Aries 2.5
BuildID: 20151201171338
Gaia: e05621cbfd92b3fb4e5aef86621c57cd68fb0414
Gecko: 89b4f90d2865e62b9d898655cf082902cf2572a0
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 44.0a2 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

--------

On Flame I only observed two states - (1) and (3) described above. I'm missing the (2) Edge state and not sure if it's dependent on my AT&T SIM or something else. For this bug I'm marking it as verified since I'm not seeing discrepancies in the 2 states observed.

Device: Flame 2.5
BuildID: 20151201163815
Gaia: 07462becf08f0c26ebd64daf89646e7403a336c5
Gecko: 33a575e711faf3344aa2e31ca2ea066b4cd8aafa
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.6
BuildID: 20151201030222
Gaia: 59c8605876736b22acaaed25be00008e452149cb
Gecko: 66a6d7ec9534b9d7847b665142fef0dd87623768
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0