1168244 - Bring WebGL formatting in line with dom module.

Status: RESOLVED INCOMPLETE

(Core :: Canvas: WebGL, enhancement)

Description

[Dan Glastonbury (:djg) | needinfo me]

:smaug has requested on a number of occasions that the dom/canvas/WebGL* files be brought into line with Mozilla coding guide. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style. (The other code in dom/canvas follows these guidelines.)

:njn put together a list of issue in order of importance: https://pastebin.mozilla.org/8834627

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Kyle, Andrew, can you work with Jeff to split this up between the two of you and schedule it?

Comment 2

[Jeff Gilbert [:jgilbert]]

I object to:
- |aFoo| for parameters
- Max 80 char line lengths
- In control statements, opening brace goes on same line (disagree for multi-line conditionals. Agree for single-line)

I don't like:
- Always brace one-line control statements

Caveats:
- Methods that override should be marked with |virtual| and |MOZ_OVERRIDE| (This is now false. Overriding methods should now be marked with `override` and not `virtual`.

Comment 3

[Jeff Gilbert [:jgilbert]]

I also don't like two-space indents, but I don't care that much. If we are doing the two-line indents, the patch should go in under my or Dan's name, to have a good default target for the commit annotation. 

We should probably have a fake user for the reformatting changes, actually.

Comment 4

[Dan Glastonbury (:djg) | needinfo me]

I'd start with reformatting to 2 spaces.

A concur with Jeff on prefixing arguments with `a`, 80 columns, etc.

Comment 5

[Jeff Gilbert [:jgilbert]]

Didn't mean to CC ethlin on this. :)