Closed Bug 1168244 Opened 6 years ago Closed 2 years ago

Bring WebGL formatting in line with dom module.

Categories

(Core :: Canvas: WebGL, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: djg, Unassigned)

References

Details

(Whiteboard: [gfx-noted])

:smaug has requested on a number of occasions that the dom/canvas/WebGL* files be brought into line with Mozilla coding guide. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style. (The other code in dom/canvas follows these guidelines.)

:njn put together a list of issue in order of importance: https://pastebin.mozilla.org/8834627
Kyle, Andrew, can you work with Jeff to split this up between the two of you and schedule it?
Flags: needinfo?(kfung)
Flags: needinfo?(acomminos)
I object to:
- |aFoo| for parameters
- Max 80 char line lengths
- In control statements, opening brace goes on same line (disagree for multi-line conditionals. Agree for single-line)

I don't like:
- Always brace one-line control statements

Caveats:
- Methods that override should be marked with |virtual| and |MOZ_OVERRIDE| (This is now false. Overriding methods should now be marked with `override` and not `virtual`.
I also don't like two-space indents, but I don't care that much. If we are doing the two-line indents, the patch should go in under my or Dan's name, to have a good default target for the commit annotation. 

We should probably have a fake user for the reformatting changes, actually.
I'd start with reformatting to 2 spaces.

A concur with Jeff on prefixing arguments with `a`, 80 columns, etc.
Flags: needinfo?(acomminos)
See Also: → 1168845
Flags: needinfo?(kfung)
No longer blocks: webgl2
Didn't mean to CC ethlin on this. :)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.