Closed Bug 1168845 Opened 5 years ago Closed 5 years ago

Update WebGL interface names to follow the spec

Categories

(Core :: Canvas: WebGL, defect)

36 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: smaug, Assigned: acomminos)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 2 obsolete files)

See the discussion in bug 974832. We have all sorts of random names exposed to the web.
We should just follow the naming from the spec.
Whiteboard: [gfx-noted]
Assignee: nobody → acomminos
See Also: → 1168244
This patch changes all WebGL extension types to match the designation from Khronos.

It also moves GLuint64 back into the WebGL2 webidl and adds GLuint64EXT to the WebGL1 webidl file as per EXT_disjoint_timer_query's spec.
Attachment #8613518 - Flags: review?(dglastonbury)
Attachment #8613518 - Flags: review?(bugs)
What are the relevant specs here, I mean urls for the specs?
Comment on attachment 8613518 [details] [diff] [review]
Update WebGL interface names to follow the spec. r=smaug r=dglastonbury

Hmm, we've exposed some interfaces (the ones which don't have [NoInterfaceObject]) in global scope.
You need to update http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_interfaces.html?force=1
Attachment #8613518 - Flags: review?(bugs) → review-
Looks like the only global scoped interface name is WebGLVertexArrayObjectOES. Updated test_interfaces.html accordingly.
Attachment #8613518 - Attachment is obsolete: true
Attachment #8613518 - Flags: review?(dglastonbury)
Attachment #8613549 - Flags: review?(dglastonbury)
Attachment #8613549 - Flags: review?(bugs)
Comment on attachment 8613549 [details] [diff] [review]
Update WebGL interface names to follow the spec. r=smaug r=dglastonbury

>+++ b/dom/tests/mochitest/general/test_interfaces.html
>@@ -1322,17 +1322,17 @@ var interfaceNamesInGlobalScope =
>     "WebGLShader",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebGLShaderPrecisionFormat",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebGLTexture",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebGLUniformLocation",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>-    "WebGLVertexArray",
>+    "WebGLVertexArrayObjectOES",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebSocket",

...
>-interface WebGLVertexArray {
>+interface WebGLVertexArrayObjectOES {
> };

So per spec WebGLVertexArrayObjectOES is [NoInterfaceObject]
in which case the entry in test_interfaces.html should be just removed.
Could you try to do those changes.
Attachment #8613549 - Flags: review?(bugs) → review+
Removed WebGLVertexArrayObjectOES from global scope.
Attachment #8613549 - Attachment is obsolete: true
Attachment #8613549 - Flags: review?(dglastonbury)
Attachment #8613591 - Flags: review?(dglastonbury)
Comment on attachment 8613591 [details] [diff] [review]
Update WebGL interface names to follow the spec. Carry r=smaug

Review of attachment 8613591 [details] [diff] [review]:
-----------------------------------------------------------------

O_O
Attachment #8613591 - Flags: review?(dglastonbury) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/524a9ccacb05
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.