1168845 - Update WebGL interface names to follow the spec

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

See the discussion in bug 974832. We have all sorts of random names exposed to the web.
We should just follow the naming from the spec.

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Update WebGL interface names to follow the spec. r=smaug r=dglastonbury

This patch changes all WebGL extension types to match the designation from Khronos.

It also moves GLuint64 back into the WebGL2 webidl and adds GLuint64EXT to the WebGL1 webidl file as per EXT_disjoint_timer_query's spec.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

What are the relevant specs here, I mean urls for the specs?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8613518 [details] [diff] [review]
Update WebGL interface names to follow the spec. r=smaug r=dglastonbury

Hmm, we've exposed some interfaces (the ones which don't have [NoInterfaceObject]) in global scope.
You need to update http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_interfaces.html?force=1

Comment 4

[Andrew Comminos [:acomminos]]

Attachment: Update WebGL interface names to follow the spec. r=smaug r=dglastonbury

Looks like the only global scoped interface name is WebGLVertexArrayObjectOES. Updated test_interfaces.html accordingly.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8613549 [details] [diff] [review]
Update WebGL interface names to follow the spec. r=smaug r=dglastonbury

>+++ b/dom/tests/mochitest/general/test_interfaces.html
>@@ -1322,17 +1322,17 @@ var interfaceNamesInGlobalScope =
>     "WebGLShader",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebGLShaderPrecisionFormat",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebGLTexture",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebGLUniformLocation",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>-    "WebGLVertexArray",
>+    "WebGLVertexArrayObjectOES",
> // IMPORTANT: Do not change this list without review from a DOM peer!
>     "WebSocket",

...
>-interface WebGLVertexArray {
>+interface WebGLVertexArrayObjectOES {
> };

So per spec WebGLVertexArrayObjectOES is [NoInterfaceObject]
in which case the entry in test_interfaces.html should be just removed.
Could you try to do those changes.

Comment 6

[Andrew Comminos [:acomminos]]

Attachment: Update WebGL interface names to follow the spec. Carry r=smaug

Removed WebGLVertexArrayObjectOES from global scope.

Comment 7

[u480271]

Comment on attachment 8613591 [details] [diff] [review]
Update WebGL interface names to follow the spec. Carry r=smaug

Review of attachment 8613591 [details] [diff] [review]:
-----------------------------------------------------------------

O_O

Comment 8

[Andrew Comminos [:acomminos]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1fc241e6a3e

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/524a9ccacb05

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/524a9ccacb05