1168502 - Trigger history syncs as a result of browsing activity

Status: NEW

(Firefox for iOS :: Sync, defect)

Comment 1

[Brian Nicholson (:bnicholson)]

Richard, is this as simple as doing a sync in the OnLocationChange notification, or are there other changes we need here?

Comment 2

[Richard Newman [:rnewman]]

(In reply to Brian Nicholson (:bnicholson) from comment #1)
> Richard, is this as simple as doing a sync in the OnLocationChange
> notification, or are there other changes we need here?

Most likely we'd add a small layer of indirection. We don't want to sync for every URL you visit.

Every time a visit causes a write to history (we ignore some types and schemes, remember!), briefly consider whether to sync. We can do that based on time, score, or some combination of the two.

If the score gets high enough, kick off a delayed background sync, just as we do for login changes:

https://github.com/mozilla/firefox-ios/blob/3f98bff332378a78f1f613d6eafa76ffed566220/Providers/Profile.swift#L650-650

As I mentioned in triage, the combination of sync on launch (Bug 1229956) and sync on exit (Bug 1168504), along with the existing 15-minute timer (which we can drop to 5 minutes) makes this bug much less important — desktop has score-based syncing, but you'd have to click links like a pro StarCraft player to sync more frequently than every five minutes.