1168704 - rename setFocusApp in nsINfcContentHelper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 1105666 we added setFocusApp in nsINfcContentHelper, however the naming is not quite right as for an app it's possible that it has multiple windows, aka multiple tabs, with different tabId (like in Notifcation).
So it should be called setFocusTab or something.

Comment 1

[Thomas Nguyen (:tnguyen)]

Attachment: Patch v1

Rename setFocusApp to setFocusTab

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8671133 [details] [diff] [review]
Patch v1

Review of attachment 8671133 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/gonk/Nfc.js
@@ +235,1 @@
>                                                  : NFC.SYSTEM_APP_ID;

nit, align ? and :

::: dom/nfc/nsINfcContentHelper.idl
@@ +124,2 @@
>                     in boolean isFocus);
>  };

update the uuid.

Comment 3

[Thomas Nguyen (:tnguyen)]

Attachment: Patch v2

Changes in patch v2
- Fix indent
- Update UUID

Comment 4

[Thomas Nguyen (:tnguyen)]

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=671a941786c5

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/39422dbd7aaa

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39422dbd7aaa