1168896 - url with fromchange and no tochange will not retrieve a list of resultsets ending with the fromchange revision

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder, defect, P3)

Description

[Cameron Dawson [:camd]]

after treeherder loads with the default url, click the "Next 10" button.
If the revision for the 11th resultset was, say, 4e05efa5ac36, then add this to the url:

    &fromchange=4e05efa5ac36

Take that URL and load it in a new tab.
Exp: should load 10 resultsets, ending with 4e05efa5ac36
Act: It loads the default most recent 10 resultsets

Comment 1

[Cameron Dawson [:camd]]

This is a service-side bug probably in the /resultsets endpoint, or perhaps in the jobs model.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Possibly related to bug 1056010?

Comment 3

[Cameron Dawson [:camd]]

(In reply to Wes Kocher (:KWierso) from comment #2)
> Possibly related to bug 1056010?

Related, yeah.  There's some oddness in that area that needs to be addressed.

Comment 4

[Cameron Dawson [:camd]]

I'm making a change in the UI to address bug 1078209 such that, if will get the right ``fromchange`` resultset, if it's within the latest 100 resultsets.  

Some deeper fixes in the jobs model will be needed to make this work correctly, and I don't want to address it in this PR: https://github.com/mozilla/treeherder/pull/560

Comment 5

[Cameron Dawson [:camd]]

The issue should be fixed in jobs.py ``get_result_set_list`` where it gets the ``result_set_ids`` initially.  To do this as I think the user would expect, we'd have to get the ``count`` resultsets in ascending order, then reverse that order so they come out descending like the UI expects.

Currently, it's doing a "less than" on the ``fromchange`` push timestamp.  But I think what the user really wants to "less than, but right up to the fromchange timestamp".

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm unable to reproduce this.