1168931 - environment.settings.defaultSearchEngine field missing from Telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

Sometimes the defaultSearchEngine field is missing from about:telemetry and the Telemetry pings. I see this on an updated Nightly e10s profile.

The browser was up for several days. No errors in devtools console. Default search settings. I am using dom.ipc.processCount > 1 on this e10s profile but it seems unrelated

This is what i see in about:telemetry#Environment/settings

Name 	Value
blocklistEnabled 	true
isDefaultBrowser 	false
e10sEnabled 	true
telemetryEnabled 	true
locale 	en-US
update.channel 	nightly
update.enabled 	true
update.autoDownload 	true
userPrefs.browser.cache.disk.capacity 	358400
userPrefs.browser.newtabpage.enhanced 	true
userPrefs.browser.shell.checkDefaultBrowser 	false

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1168931.patch

The "settings" section of the Environment was getting overwritten on preferences change, basically discarding the defaultSearchEngine.

This patch fixes the issue and adds test coverage.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8612292 [details] [diff] [review]
bug1168931.patch

Review of attachment 8612292 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryEnvironment.jsm
@@ +981,5 @@
>          autoDownload: Preferences.get(PREF_UPDATE_AUTODOWNLOAD, true),
>        },
>        userPrefs: this._getPrefData(),
>      };
> +    this._updateSearchEngine();

Nit: Empty line before that.

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: bug1168931.patch -v2

Thanks Georg!

Comment 4

[Alessio Placitelli [:Dexter]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebeee6ed18f8 (also covers bug 1165304)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9c55d9a310a2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c55d9a310a2

Comment 7

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8612316 [details] [diff] [review]
bug1168931.patch -v2

Approval Request Comment
[Feature/regressing bug #]:
Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry
This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2.
[User impact if declined]:
Data & measurement insight projects delayed or blocked with direct impact on projects depending on this.
[Describe test coverage new/current, TreeHerder]:
We have good automation coverage of the feature.
We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here.
[Risks and why]:
Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports.
We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements.
[String/UUID change made/needed]:
The only string changes were to the about:telemetry page.
We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8612316 [details] [diff] [review]
bug1168931.patch -v2

Unified telemetry is an important new feature. It is blocking some other projects. Taking it.

Comment 9

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ae167a735335