1169038 - Content for Landing Page for Learn More link in Push notification dialog in Desktop

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Bill Maggs (bmaggs)]

FF needs a landing page for Push Notification background and explanation and is coded to have it be: 

https://www.mozilla.org/en-US/firefox/push/

The content for this page has been written and edited and is here: 

https://docs.google.com/document/d/16-sqk6l_D22PFYXGaEN_8kwHrrhvvoOYx0h-OBIGF-I/edit#heading=h.449qzmjjc36s

Comment 1

[Jennifer Bertsch [:jbertsch]]

Reaching out to Bill today to ask a couple of questions.

What is the live date for this?

Thanks!

Comment 2

[Jennifer Bertsch [:jbertsch]]

Hi Bill-

I can't find you on IRC, so I'll ask some questions here:

1.  What is the live date?

2.  Is it OK if we publish this page in a template like this?  https://www.mozilla.org/en-US/firefox/interest-dashboard/

3.  Is there also a related updated to the Firefox TOS or Privacy policy that we should be expecting from Legal?

Thx,
Jen

Comment 3

[Bill Maggs (bmaggs)]

1. Ask Doug Turner. Ther relvant bug is https://bugzilla.mozilla.org/showdependencytree.cgi?id=1153499&hide_resolved=1

2. Looks great.

3. The Desktop implementation is not my thing, see #1, but I will add a NI for Mika and the legal team.

Comment 4

[Mika]

This will most likely need an update to the Firefox Browser Privacy notice to explain that Push is optional, and explain what info. enabled sites get from users.  Marshall should review the FAQ (I also have some comments).  

Jen, once you know the ship date, can you let me know so we can update the Privacy Notice accordingly?
Thanks!
mika

Comment 5

[Jennifer Bertsch [:jbertsch]]

Hi Doug-

What is the live date for this page?

Thx,
Jen

Comment 6

[Doug Turner (:dougt)]

maybe 41, probably 42.

Comment 8

[Martin Thomson [:mt:]]

Any progress on this?  It seems like we should use the doc now that it is done.

Comment 9

[Mike Alexis [:malexis]]

(In reply to Martin Thomson [:mt:] from comment #8)
> Any progress on this?  It seems like we should use the doc now that it is
> done.

Are we still targeting Fx 41 or 42? No progress yet as we've been working on other priorities.

Comment 10

[Martin Thomson [:mt:]]

The code has landed and it will ship in 42.  So Nightly users could already be encountering a 404.  I'm not asking for a rush, just an acknowledgment that someone owns this.

Comment 11

[Mike Alexis [:malexis]]

(In reply to Martin Thomson [:mt:] from comment #10)
> The code has landed and it will ship in 42.  So Nightly users could already
> be encountering a 404.  I'm not asking for a rush, just an acknowledgment
> that someone owns this.

Hi Martin,
I have triaged this with the team and have a dev lined up to take this. I'll have more info on timing shortly, but rest assured this is on our radar.

Comment 12

[Alex Gibson [:agibson]]

(In reply to Bill Maggs from comment #0)
> The content for this page has been written and edited and is here: 
> 
> https://docs.google.com/document/d/16-sqk6l_D22PFYXGaEN_8kwHrrhvvoOYx0h-
> OBIGF-I/edit#heading=h.449qzmjjc36s

Hi Matej - Is this copy doc final? I was about to pick this bug up as it seems pretty quick, but looking at the doc there is a fair bit of discussion and unresolved comments, so it's hard to tell what's final? To avoid a lot of back and forth, it would be really useful if we could tidy up the doc a bit and mark questions as resolved with regard to the final edits. This would be especially good to make sure we don't make any mistakes, before strings get exposed to localizers for translation.

Many thanks!

Comment 13

[Matej Novak [:matej]]

(In reply to Alex Gibson [:agibson] from comment #12)
> (In reply to Bill Maggs from comment #0)
> > The content for this page has been written and edited and is here: 
> > 
> > https://docs.google.com/document/d/16-sqk6l_D22PFYXGaEN_8kwHrrhvvoOYx0h-
> > OBIGF-I/edit#heading=h.449qzmjjc36s
> 
> Hi Matej - Is this copy doc final? I was about to pick this bug up as it
> seems pretty quick, but looking at the doc there is a fair bit of discussion
> and unresolved comments, so it's hard to tell what's final? To avoid a lot
> of back and forth, it would be really useful if we could tidy up the doc a
> bit and mark questions as resolved with regard to the final edits. This
> would be especially good to make sure we don't make any mistakes, before
> strings get exposed to localizers for translation.
> 
> Many thanks!

Unfortunately I'm not the owner of that doc, so I can't make edits or approve any changes. I was just asked to give it a review, but I'm not sure who created it. Sorry.

Comment 14

[Alex Gibson [:agibson]]

(In reply to Matej Novak [:matej] from comment #13)
> Unfortunately I'm not the owner of that doc, so I can't make edits or
> approve any changes. I was just asked to give it a review, but I'm not sure
> who created it. Sorry.

Ok thanks, Matej! Can anyone else CC'd on this bug please address Comment 12? It would be great to get this bug done pretty quickly if we're now hitting 404's in production.

Comment 15

[Martin Thomson [:mt:]]

I am not the owner either, but you should be able to take all the suggestions. I didn't see any unresolved discussions.

Comment 16

[Alex Gibson [:agibson]]

Ok, so I guess we need to proceed and assume all suggestions in the copy doc still showing the “resolve” button should be made. If no one is able to clean the doc up, we'll try pick through the discussion and make what changes are needed to the copy.

To avoid mistakes being made here (which going from experience is pretty easy in these circumstances), I suggest it's worth posting a screenshot of the page complete with copy for approval, before exposing strings to localisers.

Comment 18

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 19

[Alex Gibson [:agibson]]

Attachment: push-faq-collapsed.png

Comment 20

[Alex Gibson [:agibson]]

Attachment: push-faq-expanded.png

Comment 21

[Alex Gibson [:agibson]]

Hi Martin,

Could you please review the screenshots attached in Comment 19 and Comment 20 and let me now if these look ok as far as the copy goes?

One question I do have with regard to copy:

Under the section "What information do I share with a site?" we have the following copy:

"(The explanation for the permission doorhanger might read: “A site can use push to learn about you when you aren’t visiting it. [Learn more…]” or equivalent.)"

This doesn't quite make much sense to me in relation to the rest of the text. Is this correct, or am I missing something? Thanks.

Comment 22

[Martin Thomson [:mt:]]

Hi Alex,

That looks good.  Just a few small tweaks to suggest.

The last sentence of the first section (What is Push) doesn't read very well.

The second section has JavaScript spelled incorrectly.

The section paragraph of the third section (the parenthetical) can be removed.  That was a note that shouldn't have been saved.

In the last section, you should reference the MDN article instead of the push API spec: https://developer.mozilla.org/en-US/docs/Web/API/Push_API

Comment 23

[Alex Gibson [:agibson]]

(In reply to Martin Thomson [:mt:] from comment #22)
> Hi Alex,
> 
> That looks good.  Just a few small tweaks to suggest.
> 
> The last sentence of the first section (What is Push) doesn't read very well.
> 
> The second section has JavaScript spelled incorrectly.
> 
> The section paragraph of the third section (the parenthetical) can be
> removed.  That was a note that shouldn't have been saved.
> 
> In the last section, you should reference the MDN article instead of the
> push API spec: https://developer.mozilla.org/en-US/docs/Web/API/Push_API

Thanks Martin - I've made these changes. For the last sentence in the first section, how does this sound?

"You will only receive messages from sites for which you have granted permission."

Comment 24

[Martin Thomson [:mt:]]

WFM

Comment 25

[Alex Gibson [:agibson]]

Thanks - marking strings as final so we can start l10n.

Comment 26

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ae9d7729369b5bcd3683aff5ca14c41560d5a568
[fix bug 1169038] Firefox Push FAQ page

https://github.com/mozilla/bedrock/commit/a25951f22794359d25272059b745f0b7efa58871
Merge pull request #3267 from alexgibson/bug-1169038-content-landing-page-for-push-notifications

[fix bug 1169038] Firefox Push FAQ page