Closed Bug 1169089 Opened 4 years ago Closed 4 years ago

Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: sambuddhabasu1, Mentored)

References

Details

(Whiteboard: [lang=python])

Attachments

(2 files)

Both files are slightly different from each other in ways that tells me they must be both wrong. The only significant difference is the install of the yasm package from pkgs.repoforge.org, presumably because centos6's is too old.

We should merge both files, sort out what should be there that's different between them, and just make the yasm install conditional on the version yum installed (since it's also in the package list)
Hi, Шэв love to work on this. The only problem is where do I get a playground with Fedora&CentOS to test my code?
Both Fedora and CentOS come in the form of live images you can run in a virtual machine. You can find live images for older releases of both distros.
You could also use Docker. Both distros distribute Docker images.
Could not even run MozBoot on LiveCDs with latest CentOS (7 and 7.1) because it has changed distro name.
Attachment #8616450 - Flags: review?(gps)
Assignee: nobody → tim_tim2000
Status: NEW → ASSIGNED
Comment on attachment 8616450 [details] [diff] [review]
Makes mozboot run on CentOS 7.*

Review of attachment 8616450 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this for you.
Attachment #8616450 - Flags: review?(gps) → review+
Keywords: leave-open
Reassigning per IRC request.

Also, I'll be standing up automated testing for bootstrap in the next few days/weeks in bug 1245969. You can use the patches in that bug to test things on Try. You should apply for SCM level 1 access so you don't need someone to push to Try for you.
Assignee: tim_tim2000 → sambuddhabasu1
The patch presently calls "BaseBootstrapper.install_mobile_android_packages(self)" when run on CentOS as there is no "install_mobile_android_packages" defined for CentOS. I am working on implementing the function and if this patch works well, I will add the necessary in the next patch.
Attachment #8721030 - Flags: review?(mh+mozilla)
Comment on attachment 8721030 [details] [diff] [review]
Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

Review of attachment 8721030 [details] [diff] [review]:
-----------------------------------------------------------------

I think Greg has the bootstrap code paged in and would be a better reviewer.
Attachment #8721030 - Flags: review?(mh+mozilla) → review?(gps)
Comment on attachment 8721030 [details] [diff] [review]
Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

Review of attachment 8721030 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! I'll land this for you.
Attachment #8721030 - Flags: review?(gps) → review+
Blocks: 1221200
Not sure why this didn't get closed when it merged to central...
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1254908
Depends on: 1255575
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.