1169089 - Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Both files are slightly different from each other in ways that tells me they must be both wrong. The only significant difference is the install of the yasm package from pkgs.repoforge.org, presumably because centos6's is too old.

We should merge both files, sort out what should be there that's different between them, and just make the yasm install conditional on the version yum installed (since it's also in the package list)

Comment 1

[Timur Timirkhanov]

Hi, Шэв love to work on this. The only problem is where do I get a playground with Fedora&CentOS to test my code?

Comment 2

[Mike Hommey [:glandium]]

Both Fedora and CentOS come in the form of live images you can run in a virtual machine. You can find live images for older releases of both distros.

Comment 3

[Gregory Szorc [:gps]]

You could also use Docker. Both distros distribute Docker images.

Comment 4

[Timur Timirkhanov]

Attachment: Makes mozboot run on CentOS 7.*

Could not even run MozBoot on LiveCDs with latest CentOS (7 and 7.1) because it has changed distro name.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8616450 [details] [diff] [review]
Makes mozboot run on CentOS 7.*

Review of attachment 8616450 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this for you.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/23d18852de14

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23d18852de14

Comment 8

[Gregory Szorc [:gps]]

Reassigning per IRC request.

Also, I'll be standing up automated testing for bootstrap in the next few days/weeks in bug 1245969. You can use the patches in that bug to test things on Try. You should apply for SCM level 1 access so you don't need someone to push to Try for you.

Comment 9

[Sambuddha Basu [:sambuddhabasu1]]

Attachment: Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

The patch presently calls "BaseBootstrapper.install_mobile_android_packages(self)" when run on CentOS as there is no "install_mobile_android_packages" defined for CentOS. I am working on implementing the function and if this patch works well, I will add the necessary in the next patch.

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8721030 [details] [diff] [review]
Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

Review of attachment 8721030 [details] [diff] [review]:
-----------------------------------------------------------------

I think Greg has the bootstrap code paged in and would be a better reviewer.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8721030 [details] [diff] [review]
Merge python/mozboot/mozboot/centos.py and python/mozboot/mozboot/fedora.py

Review of attachment 8721030 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! I'll land this for you.

Comment 12

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da75e05b8efec6676e27fa455c7052ffa764ac36
Bug 1169089 - Merge CentOS and Fedora bootstrap code; r=gps

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da75e05b8efe

Comment 14

[Gregory Szorc [:gps]]

Not sure why this didn't get closed when it merged to central...

Comment 15

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.