1169209 - about:performance should not be listed for non-Nightly

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[rctgamer3]

There's something strange going on with about:performance in Aurora/Developer Edition (40.0a2 (2015-05-26)).
The page exists, but the underlying page/scripts seem to be missing.

File not found
Firefox can't find the file at view-source:about:performance.

Comment 1

[Jonathan Howard]

It's a nightly only feature at moment; together with slow add-on monitoring and alerts.
bug 1136927

The aurora bug is that the page is listed e.g. in about:about

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I'm tempted to make this a WONTFIX. We are definitely not ready to make about:performance ride the trains. Any objection?

Comment 3

[YF (Yang)]

However, it has been listed on about:about

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Well, too late for 40 anyway.

Comment 5

[YF (Yang)]

"about:performance" not found still occur on Fx41.0b3 & 42.0a2 (2015-08-23), 
the works for Nightly only, but listed for all on about:about page.


We expect it should not be listed for non-Nightly? changing the summary.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Fair enough.
We just need to #ifdef https://dxr.mozilla.org/mozilla-central/source/docshell/base/nsAboutRedirector.cpp#77-80, I believe.

Comment 7

[YF (Yang)]

Attachment: patch v1

I guess it works, but I am temporarily don't have a try to verification.


And, if we plan to solve the bug 1136927 quickly, we can not land this patch.
Otherwise, we may need to leave this bug open until bug 1136927 fixed, and landing an new patch to remove these lines.


Free to treat it, if you have a schedule.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca735bfdd39d

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c1c2b9fbd66f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1c2b9fbd66f