Closed
Bug 1169209
Opened 8 years ago
Closed 8 years ago
about:performance should not be listed for non-Nightly
Categories
(Toolkit :: Performance Monitoring, defect)
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: rctgamer3, Assigned: yfdyh000)
References
Details
Attachments
(1 file)
1.02 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
There's something strange going on with about:performance in Aurora/Developer Edition (40.0a2 (2015-05-26)). The page exists, but the underlying page/scripts seem to be missing. File not found Firefox can't find the file at view-source:about:performance.
Comment 1•8 years ago
|
||
It's a nightly only feature at moment; together with slow add-on monitoring and alerts. bug 1136927 The aurora bug is that the page is listed e.g. in about:about
Severity: normal → major
Component: General → Performance Monitoring
Product: Firefox → Toolkit
Version: unspecified → 40 Branch
I'm tempted to make this a WONTFIX. We are definitely not ready to make about:performance ride the trains. Any objection?
Severity: major → enhancement
Status: NEW → UNCONFIRMED
Ever confirmed: false
Well, too late for 40 anyway.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
"about:performance" not found still occur on Fx41.0b3 & 42.0a2 (2015-08-23), the works for Nightly only, but listed for all on about:about page. We expect it should not be listed for non-Nightly? changing the summary.
Severity: enhancement → minor
Status: RESOLVED → REOPENED
status-firefox40:
--- → wontfix
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Ever confirmed: true
Resolution: WONTFIX → ---
Summary: about:performance broken in 40.0a2 → about:performance should not be listed for non-Nightly
Fair enough. We just need to #ifdef https://dxr.mozilla.org/mozilla-central/source/docshell/base/nsAboutRedirector.cpp#77-80, I believe.
I guess it works, but I am temporarily don't have a try to verification. And, if we plan to solve the bug 1136927 quickly, we can not land this patch. Otherwise, we may need to leave this bug open until bug 1136927 fixed, and landing an new patch to remove these lines. Free to treat it, if you have a schedule.
Attachment #8651769 -
Flags: review?(dteller)
Attachment #8651769 -
Flags: review?(dteller) → review+
Keywords: checkin-needed
Comment 10•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c1c2b9fbd66f
Assignee: nobody → yfdyh000
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•