1169261 - implement suggestion link redirector

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

When a user gets suggestions on the Thank You page from the suggest framework, we want to be able to intuit how helpful the algorithms for generating those suggestions are. Because the links are all outbound links, we need to create a server-side redirector that captures the "click" and then redirects the user to the place they want to go.

This bug covers implementing that redirector.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Implemented google-utils ga_track_event.

PR: https://github.com/mozilla/fjord/pull/590

Landed in: https://github.com/mozilla/fjord/commit/ba2a1bdf85039defd70edb94f6e259793597188b

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

The rest of the redirector implementation in a PR: https://github.com/mozilla/fjord/pull/591

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/fjord/commit/004af6f3ebcefa00e1daccddbbd62492923c0cc3

This isn't live, so I'm just going to close it even though it's not pushed to prod, yet.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Forgot the provider version number in the event category.

Fixed in PR: https://github.com/mozilla/fjord/pull/593

Landed in: https://github.com/mozilla/fjord/commit/f1398a577020a4c802e99baf9a6d30f562925885

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

The redirector is required for measuring engagement of suggested links. Making this block the Suggest project.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

PR to make sure the redirector view is never cached: https://github.com/mozilla/fjord/pull/595

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Caching fix landed in https://github.com/mozilla/fjord/commit/ac9ac89b637072711a9b325e946770de67361f1d

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to prod just now.