1169342 - [DeviceStorage] Remove nsIDOMDeviceStorage, cleanup event code

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

Remove nsIDOMDeviceStorage as it is not used within gecko (save camera) or gaia.

nsDOMDeviceStorage overrides AddEventListener, RemoveEventListener and their permutations and explicitly forwards the other methods to DOMEventTargetHelper. It uses Add/RemoveEventListener to add/remove an observer and trigger a permission check. Since nsDOMDeviceStorage already listens on those observer events at init time, this code should be removed. For the permission check, we should switch to overloading DOMEventTargetHelper::EventListenerWasAdded which is meant for this purpose in derived classes and is triggered no matter how the listener is added.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1169342.patch, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d03da6ce58fe

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1169342.patch, v2

Build broken (although not locally!), try again.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=589dd5bd07c4

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1169342.patch, v3

Remove an unused/deprecated enum as well.

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 8612551 [details] [diff] [review]
bug1169342.patch, v3

Review of attachment 8612551 [details] [diff] [review]:
-----------------------------------------------------------------

Very Nice!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/4820fb6d8eb7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4820fb6d8eb7