[DeviceStorage] Remove nsIDOMDeviceStorage, cleanup event code

RESOLVED FIXED in Firefox 41

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

(Whiteboard: [NG Device Storage])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
Remove nsIDOMDeviceStorage as it is not used within gecko (save camera) or gaia.

nsDOMDeviceStorage overrides AddEventListener, RemoveEventListener and their permutations and explicitly forwards the other methods to DOMEventTargetHelper. It uses Add/RemoveEventListener to add/remove an observer and trigger a permission check. Since nsDOMDeviceStorage already listens on those observer events at init time, this code should be removed. For the permission check, we should switch to overloading DOMEventTargetHelper::EventListenerWasAdded which is meant for this purpose in derived classes and is triggered no matter how the listener is added.
(Assignee)

Updated

3 years ago
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Whiteboard: [NG Device Storage]
(Assignee)

Comment 2

3 years ago
Created attachment 8612425 [details] [diff] [review]
bug1169342.patch, v2

Build broken (although not locally!), try again.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=589dd5bd07c4
Attachment #8612397 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8612425 - Flags: review?(dhylands)
(Assignee)

Comment 3

3 years ago
Created attachment 8612551 [details] [diff] [review]
bug1169342.patch, v3

Remove an unused/deprecated enum as well.
Attachment #8612425 - Attachment is obsolete: true
Attachment #8612425 - Flags: review?(dhylands)
Attachment #8612551 - Flags: review?(dhylands)
Comment on attachment 8612551 [details] [diff] [review]
bug1169342.patch, v3

Review of attachment 8612551 [details] [diff] [review]:
-----------------------------------------------------------------

Very Nice!
Attachment #8612551 - Flags: review?(dhylands) → review+
https://hg.mozilla.org/mozilla-central/rev/4820fb6d8eb7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: 1169686
You need to log in before you can comment on or make changes to this bug.