Closed Bug 1169686 Opened 4 years ago Closed 4 years ago

Package error: Missing file(s): bin/components/dom_devicestorage.xpt, bin/components/pipboot.xpt

Categories

(Thunderbird :: Build Config, defect)

41 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 41.0

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=19210&repo=comm-central

Error: /builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mail/installer/package-manifest:299: Missing file(s): bin/components/dom_devicestorage.xpt

Error: /builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mail/installer/package-manifest:632: Missing file(s): bin/components/pipboot.xpt

make[3]: *** [stage-package] Error 1
pipboot.xpt was removed with https://hg.mozilla.org/mozilla-central/rev/0c1cdda7c323

dom_devicestorage.xpt was removed with https://hg.mozilla.org/mozilla-central/rev/4820fb6d8eb7
Can you do the patch to fix this?
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #8612955 - Flags: review?(rkent)
Depends on: 1164714, 1169342
Comment on attachment 8612955 [details] [diff] [review]
Remove dom_devicestorage.xpt and pipboot.xpt from package-manifest

LGTM
Attachment #8612955 - Flags: review?(rkent) → review+
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
What about removed-files.in, do files need to be added there?
I think its not necessary. Those files are not on disk because Firefox/Thunderbird ships xpt files linked together as components/interfaces.xpt in omni.ja file.
Ah yes, thanks for the clarification!
I'll land this shortly.
https://hg.mozilla.org/comm-central/rev/42fcfd06884c -> FIXED

(/im and /suite also need fixing though)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.