1169427 - Android M removes FloatMath

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

java.lang.Math has the same stuff, apparently, so we should just use that instead.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Android Lint also has the following output: `Use java.lang.Math#floor instead of android.util.FloatMath#floor() since it is faster as of API 8`

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1169427 - Replace FloatMath.*() calls with calls to Math.*(). r?snorp

Bug 1169427 - Replace FloatMath.*() calls with calls to Math.*(). r?snorp

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

This patch has been pretty much straight-forward, except for maybe DisplayPortCalculator where I had to explicitly cast from double to float. This is my guinea pig bug to try the review board. ;)

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8614741 [details]
MozReview Request: Bug 1169427 - Replace FloatMath.*() calls with calls to Math.*(). r?snorp

https://reviewboard.mozilla.org/r/10023/#review8811

Looks ok modulo these few things

::: mobile/android/base/gfx/JavaPanZoomController.java:667
(Diff revision 1)
> -    private float panDistance(MotionEvent move) {
> +    private double panDistance(MotionEvent move) {

We use float everywhere, so let's just cast the return value instead

::: mobile/android/base/gfx/JavaPanZoomController.java:800
(Diff revision 1)
> -    private float getVelocity() {
> +    private double getVelocity() {

Same here

::: mobile/android/tests/browser/robocop/MotionEventHelper.java:135
(Diff revision 1)
> -        float distance = FloatMath.sqrt((dx * dx) + (dy * dy));
> +        double distance = Math.sqrt((dx * dx) + (dy * dy));

Again, cast to float

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8614741 [details]
MozReview Request: Bug 1169427 - Replace FloatMath.*() calls with calls to Math.*(). r?snorp

Bug 1169427 - Replace FloatMath.*() calls with calls to Math.*(). r?snorp

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5c3da7a5e599

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c3da7a5e599