Closed
Bug 1169646
Opened 10 years ago
Closed 10 years ago
Left/Right shortcut navigation complains if issued before page load.
Categories
(Tree Management :: Treeherder, defect, P4)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jfrench, Assigned: camd)
References
()
Details
If you issue a left/right keyboard shortcut before Treeherder has fully loaded, it complains in the console:
TypeError: Cannot read property 'job_obj' of undefined
I encountered this while testing n,p for https://github.com/mozilla/treeherder/pull/577 which may end up using the same selection by css classes.
That being said, left/right has been in existence for months without any user complaints, and it has received heavy use. So I'm entering this as a P5.
|
Assignee | |
Comment 1•10 years ago
|
||
I made a tweak to my PR for next-prev navigation that seems to fix this.
Jon- If you get a chance, would you give it a spin? Thanks!!
https://github.com/mozilla/treeherder/pull/577
|
Reporter | |
Comment 2•10 years ago
|
||
Sure thing, coming up!
|
|
Reporter | |
Comment 3•10 years ago
|
||
Yup, seems to be fine for me now.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → cdawson
|
|
Reporter | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Fixed by:
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/20f14b8099bb945c3ab9599a8544ac7afc132177
Bug 1164545 - Sporadic incorrect previous/next unclassified
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•10 years ago
|
||
Verified fixed on production for both left/right and next/prev.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•