Indicate when a log message causes the exit status to change

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Mozharness often finishes a build, showing "TBPL SUCCESS", then returns exit status 1.  That's no fun.  I think this comes from either customization of the logging stuff, or an OutputParser -- maybe both?

At one point in debugging this, I made exit_status a property and logged every time it changed.  This helped quite a bit!

I'd like to:
 - log when the exit status changes
 - log the exit status at exit if nonzero
   - log the reason for this, if it was due to an OutputParser or logging
Blocks: 1118394

Comment 1

3 years ago
+100
Created attachment 8613599 [details]
MozReview Request: Bug 1169661: log when return_code changes; r=armenzg

Bug 1169661: log when return_code changes; r=armenzg
Attachment #8613599 - Flags: review?(armenzg)

Comment 3

3 years ago
Comment on attachment 8613599 [details]
MozReview Request: Bug 1169661: log when return_code changes; r=armenzg

https://reviewboard.mozilla.org/r/9765/#review8727

Ship It!
Attachment #8613599 - Flags: review?(armenzg) → review+

Comment 4

3 years ago
Where do you "log the reason for this, if it was due to an OutputParser or logging"?
Or is that a follow up?
Sorry, I forgot to mention that I couldn't figure out how to do that.
Comment on attachment 8613599 [details]
MozReview Request: Bug 1169661: log when return_code changes; r=armenzg

remote:   https://hg.mozilla.org/build/mozharness/rev/387cda6bb009
Attachment #8613599 - Flags: checked-in+
Also running in try on a few jobs, just to spot-check:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0fd65fa543d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.