1169821 - In Gaia Settings, "USB mass Storage" is inconsistently capitalized

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Open the Settings app.
 2. Tap the USB Storage item to enter its sub-menu (titled "Transfer Protocol")
 3. Read the text on that page.

ACTUAL RESULTS:
   Media transfer protocol (MTP)
   USB mass Storage (UMS)
            ^
Note the randomly capitalized "S" in "Storage", when the other words ("mass" & "transfer protocol" in 1st entry) are not capitalized.

EXPECTED RESULTS:
Consistent capitalization  -- the "S" should be lowercase, or "transfer" "protocol" & "mass" should be capitalized.

Link to commit that added this HTML (for bug 964601):
https://github.com/mozilla-b2g/gaia/commit/8968aa0019340e9b2837046784a231f57728c303

(This same language w/ inconsistent capitalization exists there in both the usb_storage.html file at the top, and in the settings.en-US.properties localization file further down.)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1169821 > mozilla-b2g:master

Comment 2

[[e-mail]]

Comment on attachment 8613343 [details] [review]
[gaia] gasolin:issue-1169821 > mozilla-b2g:master

Thanks for find out!

First letter cap only seems the right string pattern for descriptions.

Comment 3

[[e-mail]]

Sorry I cant recall the spec anymore, does the spec prefer to change string to All cap case `Media Transfer Protocol (MTP) / USB Mass Storage (UMS)` or with First letter cap only style?

Comment 4

[Jenny Lee]

Hi Fred,

You're right!
For label items, title case is the right pattern. So it should be: 

 Media Transfer Protocol (MTP)
 USB Mass Storage (UMS)

Thanks!

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8613343 [details] [review]
[gaia] gasolin:issue-1169821 > mozilla-b2g:master

Thanks Fred !

Comment 6

[[e-mail]]

thanks!

Comment 7

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#x51_aKjoT861ioOrZhSeYQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 8

[[e-mail]]

bootup patch has been backedout, lets land again

Comment 9

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30334

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 10

[[e-mail]]

let's do it by hand 

merged to master https://github.com/mozilla-b2g/gaia/commit/1a4ea7c84a756bb6c14d8793f490f51953c66420

thanks!

Comment 11

[Daniel Holbert [:dholbert]]

I verified that I see consistently-capitalized labels (Media Transfer Protocol, USB Mass Storage) in my current dogfood Firefox OS 3.0 build on Xperia Z3C (spark/aries device).

Marking as VERIFIED. Thanks everyone!