Closed Bug 1169821 Opened 5 years ago Closed 5 years ago

In Gaia Settings, "USB mass Storage" is inconsistently capitalized

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dholbert, Assigned: gasolin)

References

Details

Attachments

(1 file)

STR:
 1. Open the Settings app.
 2. Tap the USB Storage item to enter its sub-menu (titled "Transfer Protocol")
 3. Read the text on that page.

ACTUAL RESULTS:
   Media transfer protocol (MTP)
   USB mass Storage (UMS)
            ^
Note the randomly capitalized "S" in "Storage", when the other words ("mass" & "transfer protocol" in 1st entry) are not capitalized.

EXPECTED RESULTS:
Consistent capitalization  -- the "S" should be lowercase, or "transfer" "protocol" & "mass" should be capitalized.

Link to commit that added this HTML (for bug 964601):
https://github.com/mozilla-b2g/gaia/commit/8968aa0019340e9b2837046784a231f57728c303

(This same language w/ inconsistent capitalization exists there in both the usb_storage.html file at the top, and in the settings.en-US.properties localization file further down.)
Assignee: nobody → gasolin
Comment on attachment 8613343 [details] [review]
[gaia] gasolin:issue-1169821 > mozilla-b2g:master

Thanks for find out!

First letter cap only seems the right string pattern for descriptions.
Attachment #8613343 - Flags: review?(ejchen)
Flags: needinfo?(jelee)
Sorry I cant recall the spec anymore, does the spec prefer to change string to All cap case `Media Transfer Protocol (MTP) / USB Mass Storage (UMS)` or with First letter cap only style?
Hi Fred,

You're right!
For label items, title case is the right pattern. So it should be: 

 Media Transfer Protocol (MTP)
 USB Mass Storage (UMS)

Thanks!
Flags: needinfo?(jelee)
Comment on attachment 8613343 [details] [review]
[gaia] gasolin:issue-1169821 > mozilla-b2g:master

Thanks Fred !
Attachment #8613343 - Flags: review?(ejchen) → review+
thanks!
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#x51_aKjoT861ioOrZhSeYQ

The pull request failed to pass integration tests. It could not be landed, please try again.
bootup patch has been backedout, lets land again
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/30334

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
let's do it by hand 

merged to master https://github.com/mozilla-b2g/gaia/commit/1a4ea7c84a756bb6c14d8793f490f51953c66420

thanks!
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
I verified that I see consistently-capitalized labels (Media Transfer Protocol, USB Mass Storage) in my current dogfood Firefox OS 3.0 build on Xperia Z3C (spark/aries device).

Marking as VERIFIED. Thanks everyone!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.