Placeholder text no longer shown on about:home

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bnicholson, Assigned: wesj)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fennec+, fxios+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
STR: Close the last tab. "about:home" shows up in the URL bar, but we should see the "Enter search or address" text placeholder.
(Reporter)

Comment 1

3 years ago
Oops, wrong blocker.
Blocks: 1163120
No longer blocks: 1169272
(Assignee)

Comment 2

3 years ago
Created attachment 8613171 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/528

Argh. There's a test for the placeholder... checking
Attachment #8613171 - Flags: review?(bnicholson)
(Reporter)

Comment 3

3 years ago
(In reply to Wesley Johnston (:wesj) from comment #2)
> Created attachment 8613171 [details] [review]
> PR https://github.com/mozilla/firefox-ios/pull/528
> 
> Argh. There's a test for the placeholder... checking

Yeah, it's failing for me :)
(Reporter)

Updated

3 years ago
Attachment #8613171 - Flags: review?(bnicholson) → review+
(Reporter)

Updated

3 years ago
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
(Reporter)

Comment 4

3 years ago
https://github.com/mozilla/firefox-ios/commit/cffbfcee67db4ebab4bca468449ccec751b4bbd7
Status: ASSIGNED → RESOLVED
tracking-fennec: ? → +
Last Resolved: 3 years ago
tracking-fxios: --- → +
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.