Closed Bug 1169837 Opened 9 years ago Closed 9 years ago

remove box-sizing: padding-box from Firefox UI & Gecko tests


(Core :: CSS Parsing and Computation, defect)

Not set



Tracking Status
firefox41 --- fixed


(Reporter: zentner.kyle, Assigned: zentner.kyle, Mentored)




(1 file, 2 obsolete files)

The CSS WG resolved to remove box-sizing: padding-box, so we're removing support for it.

This bug is for tracking removal of uses from Firefox UI and Gecko tests.
Attached patch RemoveBoxSizingPaddingBoxTests (obsolete) — Splinter Review
This patch was extracted from the patch for Bug 1166728. It only removes tests and uses in Desktop, so it should be fine if the test run above is good.
Assignee: nobody → kzentner
Attachment #8613138 - Flags: review+
Blocks: 1166728
Comment on attachment 8613138 [details] [diff] [review]

r=me based on comment 2
Attached patch RemoveBoxSizingPaddingBoxTests (obsolete) — Splinter Review
This patch shouldn't be testing that padding-box support has been removed yet. This was causing mochitest failures in the first run above.
Attachment #8613138 - Attachment is obsolete: true
Attachment #8613526 - Flags: review+
Keywords: checkin-needed
Hi, this patch didn't apply cleanly:

adding 1169837 to series file
renamed 1169837 -> RemoveBoxSizingPaddingBoxTests
applying RemoveBoxSizingPaddingBoxTests
patching file toolkit/themes/shared/in-content/
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/shared/in-content/
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory

could you take a look, thanks!
Flags: needinfo?(kzentner)
Keywords: checkin-needed
Sorry about that. It seems a change in the context lines (not the content) of this diff got backed out. It applies cleanly now.
Attachment #8613526 - Attachment is obsolete: true
Flags: needinfo?(kzentner)
Attachment #8614104 - Flags: review+
Keywords: checkin-needed
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Keywords: dev-doc-needed
Oops, wrong bug.
Keywords: dev-doc-needed
For the record: in bug 1178168, we landed a patch on Aurora 41 to add back the test-pieces that we removed here, since it looks like the "box-sizing:padding-box" feature won't actually be removed until Firefox 42. (and as long as we're still shipping it, we should be testing it)

The removals from UI will be staying in for 41, though; no need to revert those changes.
You need to log in before you can comment on or make changes to this bug.