1169837 - remove box-sizing: padding-box from Firefox UI & Gecko tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Kyle Zentner]

The CSS WG resolved to remove box-sizing: padding-box, so we're removing support for it.

This bug is for tracking removal of uses from Firefox UI and Gecko tests.

Comment 1

[Kyle Zentner]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8ede1f386dc

Comment 2

[Kyle Zentner]

Attachment: RemoveBoxSizingPaddingBoxTests

This patch was extracted from the patch for Bug 1166728. It only removes tests and uses in Desktop, so it should be fine if the test run above is good.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8613138 [details] [diff] [review]
RemoveBoxSizingPaddingBoxTests

r=me based on comment 2

Comment 4

[Kyle Zentner]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d796cc494a3c

Comment 5

[Kyle Zentner]

Attachment: RemoveBoxSizingPaddingBoxTests

This patch shouldn't be testing that padding-box support has been removed yet. This was causing mochitest failures in the first run above.

Comment 6

[Carsten Book [:Tomcat]]

Hi, this patch didn't apply cleanly:

adding 1169837 to series file
renamed 1169837 -> RemoveBoxSizingPaddingBoxTests
applying RemoveBoxSizingPaddingBoxTests
patching file toolkit/themes/shared/in-content/info-pages.inc.css
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/shared/in-content/info-pages.inc.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory

could you take a look, thanks!

Comment 7

[Kyle Zentner]

Attachment: RemoveBoxSizingPaddingBoxTests

Sorry about that. It seems a change in the context lines (not the content) of this diff got backed out. It applies cleanly now.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/526f975b64e5

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/526f975b64e5

Comment 10

[Dão Gottwald [:dao]]

Oops, wrong bug.

Comment 11

[Daniel Holbert [:dholbert]]

For the record: in bug 1178168, we landed a patch on Aurora 41 to add back the test-pieces that we removed here, since it looks like the "box-sizing:padding-box" feature won't actually be removed until Firefox 42. (and as long as we're still shipping it, we should be testing it)

The removals from UI will be staying in for 41, though; no need to revert those changes.