Closed Bug 1169837 Opened 7 years ago Closed 7 years ago
remove box-sizing: padding-box from Firefox UI & Gecko tests
The CSS WG resolved to remove box-sizing: padding-box, so we're removing support for it. This bug is for tracking removal of uses from Firefox UI and Gecko tests.
This patch was extracted from the patch for Bug 1166728. It only removes tests and uses in Desktop, so it should be fine if the test run above is good.
Assignee: nobody → kzentner
Status: NEW → ASSIGNED
Attachment #8613138 - Flags: review+
Comment on attachment 8613138 [details] [diff] [review] RemoveBoxSizingPaddingBoxTests r=me based on comment 2
This patch shouldn't be testing that padding-box support has been removed yet. This was causing mochitest failures in the first run above.
Hi, this patch didn't apply cleanly: adding 1169837 to series file renamed 1169837 -> RemoveBoxSizingPaddingBoxTests applying RemoveBoxSizingPaddingBoxTests patching file toolkit/themes/shared/in-content/info-pages.inc.css Hunk #1 FAILED at 0 1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/shared/in-content/info-pages.inc.css.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory could you take a look, thanks!
Sorry about that. It seems a change in the context lines (not the content) of this diff got backed out. It applies cleanly now.
Oops, wrong bug.
7 years ago
For the record: in bug 1178168, we landed a patch on Aurora 41 to add back the test-pieces that we removed here, since it looks like the "box-sizing:padding-box" feature won't actually be removed until Firefox 42. (and as long as we're still shipping it, we should be testing it) The removals from UI will be staying in for 41, though; no need to revert those changes.
6 years ago
You need to log in before you can comment on or make changes to this bug.