Closed Bug 1280422 Opened 8 years ago Closed 8 years ago

Fix box-sizing/intrinsic-1* reftests to not use "box-sizing: padding-box"

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

We have 3 tests in the tree that use "box-sizing: padding-box" (added after we previously removed/fixed all of the other tests in bug 1169837):
http://searchfox.org/mozilla-central/source/layout/reftests/box-sizing/intrinsic-1h.html
http://searchfox.org/mozilla-central/source/layout/reftests/box-sizing/intrinsic-1k.html
http://searchfox.org/mozilla-central/source/layout/reftests/box-sizing/intrinsic-1n.html

We should remove or fix these tests before we land bug 1166728.
(As it happens, these tests don't actually have any padding, so "box-sizing:padding-box" works out to be the same as "content-box" [the default value of the property], in practice. So bug 1166728's unsupporting doesn't actually affect the rendering of these tests.)
Oops, I forgot to do this before landing bug 1166728. I'll land it as a followup instead.

We can just drop the "box-sizing" declarations from the tests, since padding-box is equivalent to content-box in these cases.

(I wasn't sure if we should make that tweak, or if that would just make these tests identical to another existing testcase alongside them in the a,b,c,...o listing of tests here [in which case we'd just want to remove them].  I've now verified that it does *not* make them identical to another such test -- all of the sibling-tests use "box-sizing:border-box" except for these 3. So they're still unique, post-tweak.)
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c5025f98e56
Remove unneeded "box-sizing: padding-box" CSS from 3 reftests, now that it's become invalid CSS. (test only, no review.)
https://hg.mozilla.org/mozilla-central/rev/3c5025f98e56
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/box-sizing-padding-box-has-been-removed/
You need to log in before you can comment on or make changes to this bug.