1169857 - Tapping the URL bar at startup shows the tab animation over the Cancel button

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

STR: Immediately tap the location text field at startup (or after adding a new tab). The tab count briefly appears over the Cancel button while in "editing mode".

Comment 2

[Brian Nicholson (:bnicholson)]

The fix here will likely fix bug 1170847, too. Alternate (easier) STR:
1) Scroll down the page to make the URL bar disappear
2) Long press a link, choose Open In New Tab
3) See the new tab animation float in the top right corner

Comment 3

[Stephan Leroux [:sleroux]]

So I see there's two approaches we can take to fix this issue:

1. Whenever the user selects 'Open New Tab', we animating in the toolbars so the user can see the tab flip animation update to the new number of tabs as feedback. Downside of this is that having the toolbars dropdown might be a bit too jarring of an experience.

2. Hide the tab flip animation from occurring when the URLBarView is collapsed. In this case, there is no visual feedback indicating that a new tab was actually created.

Darrin, any thoughts? I pushed up a branch with the show toolbars approach so you can compare.

https://github.com/mozilla/firefox-ios/tree/sleroux/Bug1169857-URLCancelAnimationBug

Comment 4

[Darrin Henein [:darrin]]

Feedback on IRC – tl;dr I like showing the toolbars on new tab, just need to delay the tab flip animation slightly so it starts once the bar is visible.

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/561

Added a fix for both the 'Open New Tab' animation issue and the Cancel button overlapping the cloned button issue.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8615417 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/561

I found bug 1171699 when testing this, but looks like this is unrelated. Seems fine to me!

Comment 7

[Stephan Leroux [:sleroux]]

Merged.