1169955 - [GTK3] selected tab color in Firefox Dark theme not consistent with System dark theme.

Status: UNCONFIRMED

(Toolkit :: Themes, enhancement)

Description

[bull500]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150530030205

Steps to reproduce:

Tabs that are selected have this white light gradient that is highly contrasting with the entire black/dark look.




Expected results:

Something in this shade would be much better for selected tabs - http://people.mozilla.org/~shorlander/private-browsing-mode/mockups/australis-pbm.png

Comment 1

[bull500]

Attachment: newtabhighlight.png

I know this is trivial but its quite annoying to have a bright spot where the tab touches the main toolbar. 
Not sure if its present on the Light theme version but it stands out on dark themes.

Comment 2

[Karl Tomlinson (:karlt)]

I'm guessing this is more about dark themes than GTK3.

Comment 3

[bull500]

Attachment: newtabltdot.png

Well the dot highlight thing also appears in the Light Theme + Persona enabled(https://addons.mozilla.org/en-US/firefox/addon/metal-texture-solid/?src=discovery-learnmore) 
So guess it both light & dark issue.  

One specific thing about the dark theme is that the "|" separator between the refresh/stop or drop down arrow on awesome bar is not at all visible.

Love the new improvement that has come to the dark theme by getting rid of the white-ish gradient.
The roundness of the back button seems imperfect though.

Another thing is the "Hamburger" menu. On all other OS's its has that a fade-in transition/animation. Its a plain pop-up on Linux versions though.

Comment 4

[Justin Dolske [:Dolske]]

This is a dupe of a known issue, which also affects other platforms.

(Also, one issue per bug, please.)

Comment 5

[bull500]

(In reply to Justin Dolske [:Dolske] from comment #4)
> This is a dupe of a known issue, which also affects other platforms.
> 
> (Also, one issue per bug, please.)
> 
> *** This bug has been marked as a duplicate of bug 995733 ***

I don't think the bug in question is a duplicate/resolved yet. The Dot issue i mentioned in comment #3 yes is a dup.
  
The dark theme color is still not the same as the default GNOME Dark Theme color value on Fedora. 
General Window color is - #393f3f
Active Tab color is - #343939
Inactive Tab Color is - #303535 

The separator between the refresh and stop buttons are still missing.
Opening preferences causes the favicon to blend into the current tab color.

Comment 6

[bull500]

I think this issue is still valid and specific to gtk3 dark themes

Comment 7

[Karl Tomlinson (:karlt)]

I've marked comment 1 and 4 off-topic to clarify that this bug is about the color of the selected tabs.  I'm not clear whether there is still a bug there or not.

Please file other bugs for other issues, as I expect they'll need different solutions, and it is getting confusing trying to work out what this bug is about.

Comment 8

[bull500]

Attachment: colorgtk3.png

(In reply to Karl Tomlinson (ni?:karlt) from comment #7)
> I've marked comment 1 and 4 off-topic to clarify that this bug is about the
> color of the selected tabs.  I'm not clear whether there is still a bug
> there or not.
> 
> Please file other bugs for other issues, as I expect they'll need different
> solutions, and it is getting confusing trying to work out what this bug is
> about.


Im adding a screenshot to depict the problem more clearly on the issue of dark theme colors.

Comment 9

[QwertyChouskie]

This is not an issue since the Quantum re-design, can this be closed?