1170149 - Performance regression in Music

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

Description

[Raptor]

On Mon Jun 01 2015, Raptor detected a possible regression in Music:

Device: flame-kk
Memory: 319
Branch: master
Time: Thu May 28 2015 18:47:26 GMT+0000 (UTC)

---

Old Average: 891.533ms
New Average: 991.456ms
Regression: 99.92ms

Confidence level of this being legitimate regression: 26.23

---

Gaia revision: 614525097bd3d5b4
Previous Gaia revision: 876ec31b51b53fa0

Gecko revision: 018a0bd47be8
Previous Gecko revision: 593a9e96af71

---

Raptor URL: http://raptor.mozilla.org/#/dashboard/script/mark.js?device=flame-kk&branch=master&memory=319&suite=coldlaunch&to=1432925246000&from=1432752446000&panelId=9&fullscreen

Comment 1

[Dominic Kuo [:dkuo]]

I think the recent music refactoring(Bug 1055049) should caused this.

Comment 3

[Dominic Kuo [:dkuo]]

Hub is going to help on this.

Comment 4

[Hubert Figuiere [:hub]]

I get a script error when I open the URL to the raptor dashboard....

Comment 5

[:Eli Perelman]

Sorry :(

http://raptor.mozilla.org/#/dashboard/script/apps.js?device=flame-kk&branch=master&memory=319&suite=coldlaunch&to=1432925246000&from=1432752446000&panelId=9&fullscreen

Comment 6

[Hubert Figuiere [:hub]]

thanks !

Comment 7

[Hubert Figuiere [:hub]]

Unconfirmed but the only obvious change in the range is 
cffd5fed56b526b24d27d9fafe5661ea100f12fb

Comment 8

[Hubert Figuiere [:hub]]

Testing right now the fix for bug 1189085 that will allow me to run raptor on these changes...

Comment 9

[Hubert Figuiere [:hub]]

Confirmed by bisect the regression. The change is quite big though.

Comment 10

[Hubert Figuiere [:hub]]

Which is a confirmation of comment 1.

Comment 11

[Hubert Figuiere [:hub]]

ModeManager.start() is one of the regressing functions.

Comment 12

[Jim Porter (:squib)]

One possibility would be to stop lazy-loading things we need immediately anyway, e.g. js/ui/views/tiles_view.js.

Comment 13

[Hubert Figuiere [:hub]]

It didn't see any improvement, actually the opposite by not lazyloading tiles_view.js. Not sure exactly why.

Comment 14

[Hubert Figuiere [:hub]]

Marking as WONTFIX as we now have landed Music-NGA that make this irrelevant.