1170226 - Wrong shistory index collected from pending tabs

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

With the landing of bug 1166757 we removed the duplicate __SS_data cache. This means that also for pending tabs the data that is sent to the child and applied immediately (shistory) is live data. Turns out that for some reason we only restore history entries but set history.index only shortly before we start restoring. If we collect data for a pending tab we might thus get the wrong shistory index (always N-1) instead of the actual index.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1170226-Restore-correct-shistory-index-when-sett.patch

Ensured that the test is failing without the patch applied.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8613608 [details] [diff] [review]
0001-Bug-1170226-Restore-correct-shistory-index-when-sett.patch

Review of attachment 8613608 [details] [diff] [review]:
-----------------------------------------------------------------

This looks like a nice simplification. I'm a little confused how we would get a problem though. After the history is restored and before the tab is fully restored, the frame script would have to send up the history data, but why would it do that? Does initial restore step of setting the history data cause us to send an update message from the frame script? I guess that would make sense, although it's an unfortunate redundancy.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Yes, applying the shistory entries and index fires SHistoryListener notifications and we're redundantly sending those to the parent again. This is unfortunate yeah but also makes the code a little simpler if we don't have to care too much about what has modified shistory :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9148fbab0a6c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9148fbab0a6c