1166757 - Remove browser.__SS_data

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Looked at what browser.__SS_data is still required for and it's only the tab icon and browser.userTyped{Value,Clear} that we need for when the tab is pending or has been restored. We should simply put those in the TabStateCache.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1166757-Remove-browser.__SS_data.patch

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8608136 [details] [diff] [review]
0001-Bug-1166757-Remove-browser.__SS_data.patch

Review of attachment 8608136 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks great. Since we restore it so early, I guess all that complexity with __SS_extdata was unnecessary even without the changes in this patch? Nice to see it gone.

::: browser/components/sessionstore/TabState.jsm
@@ +183,3 @@
>      this.copyFromCache(tab, tabData, options);
>  
> +    // Store the tab icon.

The code after copyFromCache could use a comment explaining why we do it conditionally. It's explained in SessionStore.jsm, but someone might not have seen that when looking at this code.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Bill McCloskey (:billm) from comment #2)
> Thanks, this looks great. Since we restore it so early, I guess all that
> complexity with __SS_extdata was unnecessary even without the changes in
> this patch? Nice to see it gone.

Yeah, not sure when we got to that state or if it was ever needed but there it goes.

> ::: browser/components/sessionstore/TabState.jsm
> @@ +183,3 @@
> >      this.copyFromCache(tab, tabData, options);
> >  
> > +    // Store the tab icon.
> 
> The code after copyFromCache could use a comment explaining why we do it
> conditionally. It's explained in SessionStore.jsm, but someone might not
> have seen that when looking at this code.

Will do, thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4ad0782c686c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5fb95b4c1d74

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ad0782c686c
https://hg.mozilla.org/mozilla-central/rev/5fb95b4c1d74