Closed Bug 1170370 Opened 9 years ago Closed 5 years ago

Suggested tile showing up in Classic view

Categories

(Firefox :: New Tab Page, defect)

38 Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: glandium, Unassigned)

Details

Attachments

(1 file)

Attached image Screenshot
Joey Hess reported on the Debian bug tracking system that he is getting suggested tiles in Iceweasel 38.0.1 in the Classic view (see attached screenshot). TTBOMK, the only differences between Firefox and Iceweasel relevant to the new tab page is that Iceweasel has bug 1094324 applied.

He's not seeing them immediately, though. That is, we established that opening the new tab page doesn't do a request to tiles.services.mozilla.com immediately.
"Classic" turns off the "Enhanced" functionality in 38. We did change the menu and functionality in 40 for bug 1158859 so that the options turn off all suggestions and not just the "Enhanced Tiles" part.
Huh, shouldn't there at least be a way, on 38esr and 39, to disable those without having to completely disable tiles?
Could probably change browser.newtabpage.directory.source to "data:text/plain,{}"
When observing that browser.newtabpage.enhanced is turned off? And reset when it's turned on?
Note, AFAICS in the code (but I certainly can have missed something), on 41, even when disabled, we still request to tiles.services.mozilla.com on startup. I guess that's also why we've not seen traffic to there, since that happens before the browser toolbox can be brought up, and that won't be retried for another 24 hours.
(In reply to Mike Hommey [:glandium] from comment #5)
> Note, AFAICS in the code (but I certainly can have missed something), on 41,
> even when disabled, we still request to tiles.services.mozilla.com on
> startup.
That's correct. It's so that when the user switches from no suggestions to show suggestions, we can show something immediately. As you noted, it's only fetched at most once a day. A more involved fix would be to lazily fetch on pref change.

Hello!

This bug has been closed due to inactivity and/or the potential for this bug to no longer be an issue with the new Discovery Stream-powered New Tab experience.

Please help us triage by reopening if this issue still persists and should be addressed.

Thanks!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: