Suggested tile showing up in Classic view

NEW
Unassigned

Status

()

Firefox
New Tab Page
3 years ago
3 years ago

People

(Reporter: glandium, Unassigned)

Tracking

38 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8613774 [details]
Screenshot

Joey Hess reported on the Debian bug tracking system that he is getting suggested tiles in Iceweasel 38.0.1 in the Classic view (see attached screenshot). TTBOMK, the only differences between Firefox and Iceweasel relevant to the new tab page is that Iceweasel has bug 1094324 applied.

He's not seeing them immediately, though. That is, we established that opening the new tab page doesn't do a request to tiles.services.mozilla.com immediately.

Comment 1

3 years ago
"Classic" turns off the "Enhanced" functionality in 38. We did change the menu and functionality in 40 for bug 1158859 so that the options turn off all suggestions and not just the "Enhanced Tiles" part.
(Reporter)

Comment 2

3 years ago
Huh, shouldn't there at least be a way, on 38esr and 39, to disable those without having to completely disable tiles?

Comment 3

3 years ago
Could probably change browser.newtabpage.directory.source to "data:text/plain,{}"
(Reporter)

Comment 4

3 years ago
When observing that browser.newtabpage.enhanced is turned off? And reset when it's turned on?
(Reporter)

Comment 5

3 years ago
Note, AFAICS in the code (but I certainly can have missed something), on 41, even when disabled, we still request to tiles.services.mozilla.com on startup. I guess that's also why we've not seen traffic to there, since that happens before the browser toolbox can be brought up, and that won't be retried for another 24 hours.

Comment 6

3 years ago
(In reply to Mike Hommey [:glandium] from comment #5)
> Note, AFAICS in the code (but I certainly can have missed something), on 41,
> even when disabled, we still request to tiles.services.mozilla.com on
> startup.
That's correct. It's so that when the user switches from no suggestions to show suggestions, we can show something immediately. As you noted, it's only fetched at most once a day. A more involved fix would be to lazily fetch on pref change.
You need to log in before you can comment on or make changes to this bug.