[Camera] fix remain jsdoc error

RESOLVED FIXED

Status

Firefox OS
Gaia::Camera
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: Romain Loisel, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: good-first-bug, zh)

Attachments

(2 attachments)

46 bytes, text/x-github-pull-request
gasolin@mozilla.com
: review+
Details | Review | Splinter Review
46 bytes, text/x-github-pull-request
gasolin@mozilla.com
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
Since bug 1151765 has landed and support es6 syntax for jsdoc parsing, there're still some syntax issues not resolved in gaia.

We could solve jsdoc issues per-app.
(Assignee)

Comment 1

3 years ago
I would like to work on it, can you assigned me on ?
(Reporter)

Comment 2

3 years ago
Thanks for interesting in solving this issue. The tips should be very similar to bug 1170456 which you have been taken. Good luck!
Assignee: nobody → me
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8627823 [details] [review]
PR, review
Attachment #8627823 - Flags: review?(gasolin)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8627823 [details] [review]
PR, review

looks good to me. 

Please use git commit --amend to change `r=romainloisel` to `r=gasolin` and address the comment on github.
Attachment #8627823 - Flags: review?(gasolin) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8628103 [details] [review]
PR, review

Sorry i made a mistake with my github and pollute the pull request so i made an other.
Attachment #8628103 - Flags: review?(gasolin)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8628103 [details] [review]
PR, review

merged https://github.com/mozilla-b2g/gaia/commit/aca4b2a98d5f4dc1f91b244633ef500f0f98dac6

Thank you for contribution!
Attachment #8628103 - Flags: review?(gasolin) → review+
(Reporter)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.