Closed Bug 1170458 Opened 7 years ago Closed 6 years ago

[Camera] fix remain jsdoc error

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gasolin, Assigned: me, Mentored)

References

Details

(Whiteboard: good-first-bug, zh)

Attachments

(2 files)

46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review
Since bug 1151765 has landed and support es6 syntax for jsdoc parsing, there're still some syntax issues not resolved in gaia.

We could solve jsdoc issues per-app.
I would like to work on it, can you assigned me on ?
Thanks for interesting in solving this issue. The tips should be very similar to bug 1170456 which you have been taken. Good luck!
Assignee: nobody → me
Status: NEW → ASSIGNED
Attached file PR, review
Attachment #8627823 - Flags: review?(gasolin)
Comment on attachment 8627823 [details] [review]
PR, review

looks good to me. 

Please use git commit --amend to change `r=romainloisel` to `r=gasolin` and address the comment on github.
Attachment #8627823 - Flags: review?(gasolin) → review+
Attached file PR, review
Sorry i made a mistake with my github and pollute the pull request so i made an other.
Attachment #8628103 - Flags: review?(gasolin)
Comment on attachment 8628103 [details] [review]
PR, review

merged https://github.com/mozilla-b2g/gaia/commit/aca4b2a98d5f4dc1f91b244633ef500f0f98dac6

Thank you for contribution!
Attachment #8628103 - Flags: review?(gasolin) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.