Closed
Bug 1170463
Opened 9 years ago
Closed 9 years ago
[Settings] fix remain jsdoc error
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: yuwen41200.cs03, Mentored)
References
Details
(Whiteboard: good-first-bug, zh)
Attachments
(1 file)
Since bug 1151765 has landed and support es6 syntax for jsdoc parsing, there're still some syntax issues not resolved in gaia. We could solve jsdoc issues per-app.
Assignee | ||
Comment 1•9 years ago
|
||
I would like to fix the bug. Need more info.
Flags: needinfo?(gasolin)
Reporter | ||
Comment 2•9 years ago
|
||
Thanks for interesting in solving this issue. First you need run `npm install` in gaia repo to get up-to-date packages. Then run command `gulp jsdoc:settings` to make sure everything works. You can remove exclude files from jsdoc.json, fix the file and run the command again to check if jsdoc is actually fixed.
Assignee: nobody → yuwen41200.cs03
Flags: needinfo?(gasolin)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8622097 -
Flags: review?(gasolin)
Assignee | ||
Updated•9 years ago
|
Attachment #8622097 -
Attachment filename: file_1170463.txt → Github pull request #30583
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8622097 [details] [review] [gaia] yuwen41200:master > mozilla-b2g:master Thanks for providing the patch! Mostly looks good to me. I've leave some comment in github, please check it and set review again to the module owner (arthur.chen@mozilla.com).
Attachment #8622097 -
Flags: review?(gasolin)
Assignee | ||
Updated•9 years ago
|
Attachment #8622097 -
Flags: review?(arthur.chen)
Comment 5•9 years ago
|
||
Comment on attachment 8622097 [details] [review] [gaia] yuwen41200:master > mozilla-b2g:master Thanks for the effort. Please check my comments in github.
Attachment #8622097 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 6•9 years ago
|
||
Thanks! I've updated my petch.
Assignee | ||
Updated•9 years ago
|
Attachment #8622097 -
Flags: review?(arthur.chen)
Comment 7•9 years ago
|
||
Comment on attachment 8622097 [details] [review] [gaia] yuwen41200:master > mozilla-b2g:master r=me, thanks!
Attachment #8622097 -
Flags: review?(arthur.chen) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8622097 [details] [review] [gaia] yuwen41200:master > mozilla-b2g:master Fred, please help check if the patch does fix all errors, thanks.
Attachment #8622097 -
Flags: feedback?(gasolin)
Reporter | ||
Comment 9•9 years ago
|
||
Comment on attachment 8622097 [details] [review] [gaia] yuwen41200:master > mozilla-b2g:master looks good to me and the generated result works. Will help land the code once gaia is reopen.
Attachment #8622097 -
Flags: feedback?(gasolin) → feedback+
Reporter | ||
Comment 10•9 years ago
|
||
merged https://github.com/mozilla-b2g/gaia/commit/ad8a87ddd3d255f34f5f58893010ddbaf5fa0d72
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•