1170500 - [Mac] Broken one-off search items layout

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Florian Quèze [:florian]]

Attachment: Fix

Here is a screenshot of the problem: http://cl.ly/image/0L2N1g0Z3r2P

It looks like this has been regressed by bug 459563 / http://hg.mozilla.org/mozilla-central/rev/6d88bce884dc#l5.15

The attached patch makes the Mac CSS be more similar to the Windows one.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 8613993 [details] [diff] [review]
Fix

> .search-panel-one-offs {
>+  margin: 0 0 !important;

margin: 0 !important;

Comment 3

[Florian Quèze [:florian]]

(In reply to Dão Gottwald [:dao] from comment #1)
> Comment on attachment 8613993 [details] [diff] [review]
> Fix
> 
> > .search-panel-one-offs {
> >+  margin: 0 0 !important;
> 
> margin: 0 !important;

This is a good simplification in general, but in this specific case I care more about making the Mac CSS be closer to the Windows/Linux ones, so that we have an easier time de-duplicating (when finishing attachment 8530892 [details] [diff] [review]).

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/612e73e50be6

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/612e73e50be6

Comment 7

[Florian Quèze [:florian]]

Hopefully we'll add a test to prevent further regressions like this one in bug 1107178.