Closed Bug 1107178 Opened 10 years ago Closed 5 years ago

add test coverage for one-off buttons

Categories

(Firefox :: Search, defect, P4)

Product:
Firefox
Component:
Search
Type:
defect
Points:
5

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: mossop, Unassigned)

References

Details

(Whiteboard: [ui][fxsearch])

No description provided.
Flags: qe-verify-
Flags: firefox-backlog+
Let's define this a bit more completely - what tests do we most need? What's the minimal set that will offer the most regression-protection for common areas that we're currently changing?
Flags: needinfo?(florian)
Flags: needinfo?(dtownsend)
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #1) > Let's define this a bit more completely - what tests do we most need? What's > the minimal set that will offer the most regression-protection for common > areas that we're currently changing? Dave already added a good set of tests about the search panel showing/hiding. The tests we need the most at this point are tests for the one-off buttons, and more generally the new pieces of UI we added with bug 1088660 (that includes for example the headers shown in the search panel).
Flags: needinfo?(florian)
Points: --- → 8
Summary: New search UI needs tests → add test coverage for one-off buttons and new search UI headers
I filed bug 1120641 and bug 1120642 to cover other pieces.
Points: 8 → 5
Flags: needinfo?(dtownsend)
Summary: add test coverage for one-off buttons and new search UI headers → add test coverage for one-off buttons
Priority: -- → P4
Whiteboard: [fxsearch][searchui]
Rank: 45
Whiteboard: [fxsearch][searchui] → [ui][fxsearch]
Tests here should not only ensure that the one-off buttons work, but also verify that the layout is correct, so that in the figure we could catch immediately regressions like bug 1170500. We can probably do this by checking the computed height of the description element containing the one-off buttons.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.