1170550 - Crash in ServiceWorkerRegisterJob::ContinueInstall when registering a service worker which has a syntax error caused by a strict mode violation

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

Such scripts will run into their error way later than normal syntax errors, under a stack like this: https://pastebin.mozilla.org/8835424

But also, scriptloader::LoadMainScript would return true, and we mark the worker private as successfully executed its script in CompileScriptRunnable::WorkerRun(), but later on, we crash like this https://pastebin.mozilla.org/8835425 because we fail to null check mRegistration before dereferencing it.

Comment 1

[(no longer active)]

Attachment: Don't crash when registering a service worker which has a strict mode error

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/959c2bd7e15e

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/959c2bd7e15e