117059 - Redundant `Encrypt Sensitive Information' and `Obscure Sensitive Information' menu items

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[Matthew T (active 1999-2002)]

Build: 2001122508, Mac OS 9.1

To reproduce:
1.  Open the `Tasks' > `Privacy & Security' > `Password Manager' nightmare
    subsubmenu.
2.  Look in the second half of the menu.

What you see:
*   `Encrypt Sensitive Information' and `Obscure Sensitive Information' items,
    one of which is always disabled.

What you should see:
*   No such items.

These two menu items represent one of the most obscure preferences in Mozilla, 
and there is already UI for the preference in the Preferences dialog. There is 
no need for it to be in the menus as well.

Comment 1

[Håkan Waara]

Need reviews here as well.

Comment 2

[Håkan Waara]

Attachment: Fix for this bug

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 62831 [details] [diff] [review]
Fix for this bug

r=bzbarsky assuming morse and trudelle are fine with this

Comment 4

[Håkan Waara]

CC morse

Comment 5

[Stephen P. Morse]

I would agree that making this one item instead of two would be a good idea.  
But I would not be happy to see it removed completely from the menu.

Comment 6

[Matthew T (active 1999-2002)]

Morse, could you give one or two reasons why the least-often changed pref in
Mozilla should have a menu item, while (for example) automatically loading
images does not? I know programmers usually overestimate the importance of the
features which they coded relative to the project as a whole, but this
particular example seems a bit excessive.

Comment 7

[Stephen P. Morse]

1. I believe that the ability to encrypt/obscure is important for security 
reasons, whether or not it is frequently used.  So it should be easy to find.  
If it's in more than one place, that makes it easier to find.

2. I believe that the ability to encrypt/obscure is something that belongs 
together with the other password-manager menu items.

Comment 8

[Peter Trudelle]

I'd question the need for these or any other commands in a third-level menu. It
sounds especially dangerous to offer me the Obscure choice after I have already
specified Encryption.  Wouldn't that reduce my security?  Also, having things in
multiple places makes *everything* harder to find, since there are more choices. 

However, instead of individual bugs for changing each bit of UI for this
feature, I'd prefer to see a spec revision proposed, assuming a spec for the
current behavior exists.  I'm not sure when we'd have time to implement it, but
I'd rather deal with bugs like this as part of a coherent design rather than
one-off.  Is there a UI spec for the current behavior?

Comment 9

[sairuh (rarely reading bugmail)]

see also bug 32502: simplify the Tasks menu, which touches on comment 8.

Comment 10

[Håkan Waara]

.

Comment 11

[Blake Ross]

-> morse

Comment 12

[Matthew T (active 1999-2002)]

This bug was fixed as part of bug 108099. Thankyou very much, Blake.

Comment 13

[Matthew T (active 1999-2002)]

Ok, Blake has pointed out to me that these incomprehensibilities are still 
residing in the `Password Manager' submenu of the `Tools' menu. Reopening.

Comment 14

[Daniel Veditz [:dveditz]]

Where? I see only "Log out" and "Manage stored passwords"

Comment 15

[John Unruh]

Works for me with the 7/23 trunk Mac OSX build.

Comment 16

[sairuh (rarely reading bugmail)]

mass-verifying WorksForMe bugs.

reopen only if this bug is still a problem with a *recent trunk build*.

mail search string for bugspam: AchilleaMillefolium