Closed Bug 108099 Opened 23 years ago Closed 22 years ago

restructure menu framework for browser and mail

Categories

(SeaMonkey :: General, defect, P2)

Product:
SeaMonkey
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Depends on 2 open bugs,
URL
)

Details

(Whiteboard: landing monday, april 1)

Attachments

(2 files)

comparison of File & Tools menus
80.20 KB, image/gif
Details
patch
174.40 KB, patch
bugs
: review+
hewitt
: superreview+
Details | Diff | Splinter Review 
back in September, german and jennifer came up with some really interesting menu
proposals. here are links to screenshots of the menus --for the browser and mail
windows [note: keyboard shortcuts are not part of these proposals, and only
reflect the current incomplete design state]:

Prototype A (Navigator and Mail shown):
http://www.mozilla.org/projects/ui/communicator/framework/menu_framework/menuproto_screenshots/a/nav/
http://www.mozilla.org/projects/ui/communicator/framework/menu_framework/menuproto_screenshots/a/mail/

Prototype B (Navigator shown):
http://www.mozilla.org/projects/ui/communicator/framework/menu_framework/menuproto_screenshots/b/nav/

Prototype C (Navigator and Mail shown):
http://www.mozilla.org/projects/ui/communicator/framework/menu_framework/menuproto_screenshots/c/nav/
http://www.mozilla.org/projects/ui/communicator/framework/menu_framework/menuproto_screenshots/c/mail/

they were subsequently discussed with enthusiasm at a pixeljockeys meeting. B
and C were the preferred prototypes. here's a summary from what i recall [anyone
who was also there, feel free to jump in a clarify/correct me where needed!]:

1. keep the Search menu, including Find/Find Again --german and jennifer had an
excellent argument for this. i'll let jglick discuss that in more detail, if she
wishes, as she'd be a lot more articulare [and have better memory] than me. ;)

2. keep the Go menu. for the browser, History-related items would then be moved
from Tasks > Tools to here. for mail, Go allows a user to 'jump' to a given
message or account.

3. in mail, keep the Message menu, as it allows a user to 'do actions to/with' a
given message.

4. [biggie] refactor Tasks menu. iirc, we wanted either Prototype B, where there
would be Tools and Window menus, or Prototype C, where there would be Features
and Window menus. the main difference btwn these two is that the Window menu in
B lists only window-oriented items [tile, arrange and the open windows]
--whereas the Window menu in C includes both window-oriented items *and*
applicaions [mail, composer, addrbk, navigator, etc.].

i think that UI was going to research usability data [if available] concerning
(4), to see if there'd be a stronger call for B or C.
Blocks: 102472
Depends on: 32502, 48748, 102592
QA Contact: zach → sairuh
Isn't this a dup of bug 106577?
*** Bug 106577 has been marked as a duplicate of this bug. ***
Depends on: 69555
Depends on: 67414
To reiterate my complaint from the dupe, I, as well as Mozilla's UI owner,
believe the window menu and functions need to go. (window list, and the new
tile/arrange). Mozilla is not an SDI application. Therefore, it has *NO* need
for any of those menu items. The window manager does them all, and better.
Comments on B:

- It looks like the Help menu only points to web sites ("Help and Support 
Center").  What if you're offline, or having trouble getting Mozilla to use a 
mandatory proxy?

- Why does "My Sidebar" in the view menu become a submenu?  What's in the 
submenu?

- "Add to bookmarks in..." doesn't indicate that it also lets you change the 
name of the bookmark, but maybe that's not possible without a really long menu 
item.

- Including 7 folders of global history on the Go menu will make the menu very 
long if the are more than a few session history entries.  Since you're not 
likely to remember exactly which day you visited a site after several days, how 
about:

  Back                   Alt+left arrow
  Forward                Alt+right arrow
  Up                     Alt+up arrow      (bug 33684)    
  Home                   Alt+home
 --------------------------------
  First in session history
/ Current in session history         (/ is a check mark or bullet)
  Last in session history
  --------------------------------
  Visited today >
  Visited yesterday >
  Visited 2 days ago >
  Complete history...    Accel+H
attachment 56327 [details] from bug 106577 is a nice comparison btwn Opera, IE and
mozilla.
Blocks: 110354
Depends on: 103417
*** Bug 111212 has been marked as a duplicate of this bug. ***
Blocks: 93390
No longer blocks: 93390
Depends on: 89975
Depends on: 92499
*** Bug 114481 has been marked as a duplicate of this bug. ***
Blocks: 114556
Depends on: 114803
Depends on: 105028
Depends on: 92901
Depends on: 63134
Depends on: 75546
what's the priority and target for this bug? is this work we still plan to have
completed for MachV?
The plan is to work on this bug in the 0.9.9 timeframe when features have
settled a bit more. The menu work is low risk and can go in later than other
features. 
Since you have a plan, can you update the "target milestone" field to reflect 
that?
Target Milestone: --- → mozilla1.0
We will work on finalizing the spec in the 0.9.9 timeframe with the intent of
having the menu rework done in the 1.0 timeframe.
Priority: -- → P2
does this jive with the M1.0(i.e. will drivers allow these changes to be checked
in), and current MachV schedule?
Blocks: 89825
Depends on: 79639
We will probably need to pull this work into 0.9.9, possibly early in 0.9.9,
depending on whether any feature work stays in the schedule.
Blocks: 114476
Depends on: 120358
bug 67414: removing the Search menu was removed from the dependency list, but i
think it should still be mentioned here/kept in mind for this meta/design bug. :)
bug 48748: Tasks menu should be called Window was removed from the dependency
list, but i think it should still be mentioned here/kept in mind for this
meta/design bug. [to keep track of, at least for me, heh.]
fyi (regarding last nav issues meeting), german's rough plan was option "b",
located here:

http://rocknroll/users/marlon/publish/german/menu_prototypes/

note - still in development/under review. see possible feature work under the
"go" menu.  however, majority of the work is simply reorg.
Blocks: 121054
Depends on: 47139
Depends on: 122144
Depends on: 122505
Depends on: 124484
marlon, would it be possible to put that url on a non-internal server?
Depends on: 126059
Christian - please read the initial bug description to check out Prototype B.
No longer depends on: 126059
Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to adt@netscape.com.  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.
Target Milestone: mozilla1.0 → mozilla1.2
Keywords: nsbeta1
Target Milestone: mozilla1.2 → mozilla1.0
Approving for 1.0 milestone. Menu rework necessary for usability and access to
new features.
Keywords: nsbeta1 → nsbeta1+
*** Bug 129922 has been marked as a duplicate of this bug. ***
*** Bug 129922 has been marked as a duplicate of this bug. ***
http://bugzilla.mozilla.org/show_bug.cgi?id=129922
I have recently submited that bug which has been marked as a duplicate of this
bug. There, Cormac F. write me to place my comments in this bug.





*(Please take time to review this to then post the comments, approves and
disagreements)*

NAVIGATOR MENU:

This is radical change which will affect to all Mozilla.
I have reviewed all the actual options of the navigator menu.
I categorized them and this is what i think:





_______________________________________________________________________________
|Mozilla |Window |Navigation |Bookmarks |Page |Edit |Tools |Help |Debug |QA 



1.\
[Mozilla]
·--------------------·
| New              >-|--------------------------·
|--------------------|  | · Message             |
| Navigator          |  | · Address Book Card   |
| Mail & Newsgroups  |  ·-----------------------·
| IRC Chat           |
| Composer           |
| Address Book       |
|--------------------|
| Preferences        |
|--------------------|
|*Apply Theme*     > |   *( It can be setup into 'Preferences'.
|--------------------|     \ I guess doesnt qualify enough
| Work Offline       |      \ for have it out into a menu too.
|--------------------|       )*
| Close              |
| Exit               |
·--------------------·

*If user wants to be open a new navigator window, just click 'Navigator'.
*May this menu should be named [Browser]



2.\
[Window]
·---------------------------·
| Show/Hide               >-|----------------------·
| Sidebar                   |  | · All bars        |
| Turn to Full Screen Mode  |  | · and Toolbars    |
·---------------------------·  ·-------------------·

*I am not sure about the name of this menu, may be just [View]



3.\
[Navigation]
·--------------------.
| Back               |
| Forward            |
| Reload             |
| Stop               |  
| Go               >-|-----------------------------·
|--------------------|  | · mozilla.org            |
| Open Location...   |  | · latinmoz.org           |
|--------------------|  | · MozillaMoonWalker.org  |
| New Tab            |  | · ...etc.                |
| Close Tab          |  ·--------------------------·
| Go To Tab        >-|-----------------· 
|--------------------|  | · Tabs       | 
| History            |  | · Actually   |
·--------------------·  | · Opened     | 
                        ·--------------·



4.\
[Bookmarks] 
...
*Is Ok.



5.\
[Page]
·--------------------------·
| Find in this Page...     |
| Find Again               |
| Translate                |
|--------------------------|
| Send Page                |
| Send Link                |
|--------------------------|
| Edit Page                |
| Save Page As             |
|--------------------------|
| Print                    |
| Print Preview            |
|*Print Setup*             |  *( or its actual name, 'Page Setup'
|--------------------------|    )*
| Text Zoom              > |
| Use Stylesheet         > |
|*Language and Web Content*|  *( can be setup into 'Preferences',
| Character Coding       > |    \ and i guess is not relevant enough for
|--------------------------|     \ have it out into menu too.
| Page Source              |      )*
| Page Info                |
·--------------------------·



6.\
[Edit]
·-------------·
| Undo        |
| Redo        |
|-------------|
| Select All  |
| Paste       |
|-------------|
| Cut         |
| Copy        |
| Delete      |
·-------------·



7.\
[Tools]
·--------------------------·
| Prefill Form             |
| Save Form Data           |
| Manage Saved Data        |
|--------------------------|
| DOM Inspector            |
| Import Utility           |
| Java Console             |
| JavaScript Console       |
| JavaScript Debbuger      |
|------------------------- |
| Privacy and Security   > |
·--------------------------·



8.\
[Help] 
...
*Is Ok.



9.\
[Debug] 
...
*Is Ok.



10.\
[QA] 
...
*Is Ok.
I like some of the changes Lancer suggests, BUT

- Edit should always be the second menu
- Window should always be somewhere at the end, in our case, left of Help, Debug, QA
- Your Window menu is really the View menu. A Window(s) menu is supposed to
enumerate open windows, as we currently do in our Tasks menu.
 Is true the 'Window' menu i suggest, it is almost the actual 'View' menu, but
it is not. This one i am suggesting wants to mean this: if you select one of the
options placed into that menu, you will modify the window; because, for
explample, hiding the navigation toolbar and/or showing the sidebar, makes
resize the space where the web page is renderd. 

The opened windowS has to be enumerated in the principal menu of Mozilla. The
one named [Mozilla]


[Mozilla]
·--------------------·
| New              >-|------------------------·
|--------------------|  | Message             |
| Navigator          |  | Address Book Card   |
| Mail & Newsgroups  |  ·---------------------·
| IRC Chat           |
| Composer           |
| Address Book       |
|--------------------|
| Preferences        |
|--------------------|
| · all the mozilla  |
| · aplications      |
| · actualy          |
| · opened           |
|--------------------|
| Work Offline       |
|--------------------|
| Close              |
| Exit               |
·--------------------·

And this menu has to be the same in all Mozilla, but for the options into the
[New] submenu.

I dont understand why [Edit] should always be the second menu.
No longer depends on: 103417
Depends on: 132436
Looking at the proposal, I believe all the print options should be in a submenu
so it appears less bloated.


Three items is pretty standard (Print Plus is strictly a Netscape problem), and
I can't recall any popular app that buried print functionality in a submenu.  
A note of caution: it's generally not a good idea to have a submenu as the 
first item in a menu the way things are being planned for the file menu.  If 
you have:

[File]
·--------------------·
| New              >-|--------------------------·
|--------------------|  | · Message             |
| Navigator          |  | · Address Book Card   |
| Mail & Newsgroups  |  ·-----------------------·
| IRC Chat           |

then keep in mind that many users will have difficulty moving their cursor 
laterally for the large distance that is required to access the "New" submenu.  
From my experience, people "jiggle" their mouse and it rises so that they 
accidentally open one of the other primary level menus like "Edit" 
or "Search".  This is a problem with Internet Explorer's menu implementation - 
I've seen it in my usability studies.  Advanced users usually have more 
developed mouseing skills.  

A better approach is to have at least one non-menu item before the "New" 
submenu.  Netscape4 had a "New Window" option in that place, for example.  
> A better approach is to have at least one non-menu item before the "New" 
> submenu.  Netscape4 had a "New Window" option in that place, for example.

It did?  Not the version of Netscape 4 that I'm running.  It contains:

   new        -> submenu
   open page
   ---------
   save as
   save frame as
   --------
   ...
Depends on: 133288
*** Bug 32502 has been marked as a duplicate of this bug. ***
-> me
Assignee: marlon → blaker
Joshua:

Would providing a delay before opening one of the other menus give the users
time to move their mouse back to the right place?

You touched on one of the main problems. Most developers are advanced computer
users and don't know what its like not being one since it was many many years
ago they were like that.

That's why those usability studies are so important.

Can you please provide a link to the results of your usability studies? 
An update: it would be foolish to minus this now; the work is done and pending
review.  It will be in the tree by the end of the day today (Monday).
Whiteboard: landing monday, april 1
Adding putterman to cc: list
adt1.0.0+ approval for checkin, pending detailed unit testing on all platforms
and r/sr=.
Keywords: adt1.0.0+
Attached patch patch — — Splinter Review 

    
    

    
  
Comment on attachment 77182 [details] [diff] [review]
patch

sr=hewitt

        Attachment #77182 -
        Flags: superreview+

    
    

    
  
Patch tells me this on a fresh CVS tree:

patching file xpfe/communicator/resources/content/contentAreaContextOverlay.xul
Hunk #2 FAILED at 108.

patching file xpfe/communicator/resources/content/nsContextMenu.js
:patch: **** malformed patch at line 3428: 

There are some AIM stuff in there that I have to skip from applying, but I guess
that's on purpose.


    
    

    
  
Marking fixed. Please file specific bugs about specific issues at this point.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
-<!ENTITY bookmarksMenu.accesskey "b">
-<!ENTITY addCurPageCmd.label "Add Bookmark">
-<!ENTITY addCurPageCmd.accesskey "b">
+<!ENTITY bookmarksMenu.accesskey "">
+<!ENTITY addCurPageCmd.label "Add to Bookmarks">
+<!ENTITY addCurPageCmd.accesskey "B">

Blake, did you mean to remove the accesskey from the bookmarks menu?

    
    

    
  
Ugh, the lack of "New Navigator Window" at the top of "File" is driving me crazy
in the build I just downloaded. Please consider putting this back. Bug #135571.

    
    

    
  
I've filed another bug 135573 for another issue.

    
    

    
  
Using:

Mozilla 0.9.9+
Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.9+) Gecko/20020406

i have seen the new items 'order' of the navigator menu bar.

i believe, it is...   ...useless if the user wants to use the navigator without
the tab bar and the toolbars.

i believe it most be reordered.

    
    

    
  
vrfy'ing fixed.

as blake mentioned in comment 41 --new issues should be filed as new bugs.
Status: RESOLVED → VERIFIED
Summary: restructure menu framework [Go, Tasks] for browser and mail → restructure menu framework for browser and mail

    
  
Component: User Interface Design → Browser-General

    
  
No longer depends on: 92499
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: