Closed Bug 1170647 Opened 9 years ago Closed 9 years ago

[Music] [Front-end] Add unit tests for ui/views/search_view.js

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S3 (24Jul)

People

(Reporter: dkuo, Assigned: hub)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30863
46 bytes, text/x-github-pull-request
squib
: review+
Details | Review 
Currently ui/views/search_view.js lacks for the unit tests so let's add them.
Assignee: nobody → hub
Status: NEW → ASSIGNED
Comment on attachment 8630630 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30863

Require the other bug to land, hence two commits.
Attachment #8630630 - Attachment description: [gaia] hfiguiere:bug1170647-search-view-tests > mozilla-b2g:master → Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30863
Attachment #8630630 - Flags: review?(dkuo)
Depends on: 1170658
Attachment #8630630 - Flags: review?(dkuo) → review?(squibblyflabbetydoo)
Comment on attachment 8630630 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30863

Looks good!
Attachment #8630630 - Flags: review?(squibblyflabbetydoo) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/6f910ab15a96c0c23645a32b0f3fddf7d912b292
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: