Show a warning when a user attempts to install an unsigned add-on (if the pref allows)

VERIFIED FIXED in Firefox 41

Status

()

Firefox for Android
Add-on Manager
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

35 Branch
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox41 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
Android version of bug 1148021.
(Assignee)

Comment 1

3 years ago
Created attachment 8616804 [details]
MozReview Request: Bug 1170843 - Show a warning when a user attempts to install an unsigned add-on. r=mfinkle

Bug 1170843 - Show a warning when a user attempts to install an unsigned add-on. r=mfinkle
Attachment #8616804 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

3 years ago
Created attachment 8616806 [details]
screenshot

This isn't really pretty, but right now we only support a single text message in these prompts, so this is the best I can do without a lot more effort.

I don't think this is so bad, and this wouldn't been seen by release users, so I don't care to make it better.
(Assignee)

Comment 3

3 years ago
Actually, Anthony has a mock-up for this in bug 1170043, so I should probably update this patch to follow that more closely.

Anthony, the current install notification includes the name of the add-on, but the name isn't included in your mock-up. Should I include it?

I do see you included the name of the add-on in the "Verified add-on" install dialog (although I couldn't implement the blue color for the add-on name without more extensive changes). We don't currently have a bug filed for changing the regular install dialog, so I can file another bug for this.
Flags: needinfo?(alam)
I don't think we can add the little images in the top/left corner of the dialog, can we? Your dialog looks OK as a first draft.
Comment on attachment 8616804 [details]
MozReview Request: Bug 1170843 - Show a warning when a user attempts to install an unsigned add-on. r=mfinkle

https://reviewboard.mozilla.org/r/10477/#review9239

Ship It!
Attachment #8616804 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 6

3 years ago
(In reply to Mark Finkle (:mfinkle) from comment #4)
> I don't think we can add the little images in the top/left corner of the
> dialog, can we? Your dialog looks OK as a first draft.

Yeah, I talked with Anthony about that, and it would just be a "nice to have". I think we would need to change our prompt implementation if we want to support that, so definitely not a requirement here.
Created attachment 8617568 [details]
prev_installwarned_temp.png

Works for me! Can we have the name of the add-on below, like this? and the title change too?
Flags: needinfo?(alam) → needinfo?(margaret.leibovic)
(Assignee)

Comment 9

3 years ago
(In reply to Anthony Lam (:antlam) from comment #7)
> Created attachment 8617568 [details]
> prev_installwarned_temp.png
> 
> Works for me! Can we have the name of the add-on below, like this? and the
> title change too?

Yep, updated the patch and landed it.
Flags: needinfo?(margaret.leibovic)
https://hg.mozilla.org/mozilla-central/rev/3543d6a877ea
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41

Comment 11

3 years ago
Verified as fixed on Firefox 41 Beta 1
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.