1170843 - Show a warning when a user attempts to install an unsigned add-on (if the pref allows)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[:Margaret Leibovic]

Android version of bug 1148021.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1170843 - Show a warning when a user attempts to install an unsigned add-on. r=mfinkle

Bug 1170843 - Show a warning when a user attempts to install an unsigned add-on. r=mfinkle

Comment 2

[:Margaret Leibovic]

Attachment: screenshot

This isn't really pretty, but right now we only support a single text message in these prompts, so this is the best I can do without a lot more effort.

I don't think this is so bad, and this wouldn't been seen by release users, so I don't care to make it better.

Comment 3

[:Margaret Leibovic]

Actually, Anthony has a mock-up for this in bug 1170043, so I should probably update this patch to follow that more closely.

Anthony, the current install notification includes the name of the add-on, but the name isn't included in your mock-up. Should I include it?

I do see you included the name of the add-on in the "Verified add-on" install dialog (although I couldn't implement the blue color for the add-on name without more extensive changes). We don't currently have a bug filed for changing the regular install dialog, so I can file another bug for this.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't think we can add the little images in the top/left corner of the dialog, can we? Your dialog looks OK as a first draft.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8616804 [details]
MozReview Request: Bug 1170843 - Show a warning when a user attempts to install an unsigned add-on. r=mfinkle

https://reviewboard.mozilla.org/r/10477/#review9239

Ship It!

Comment 6

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> I don't think we can add the little images in the top/left corner of the
> dialog, can we? Your dialog looks OK as a first draft.

Yeah, I talked with Anthony about that, and it would just be a "nice to have". I think we would need to change our prompt implementation if we want to support that, so definitely not a requirement here.

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_installwarned_temp.png

Works for me! Can we have the name of the add-on below, like this? and the title change too?

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3543d6a877ea

Comment 9

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #7)
> Created attachment 8617568 [details]
> prev_installwarned_temp.png
> 
> Works for me! Can we have the name of the add-on below, like this? and the
> title change too?

Yep, updated the patch and landed it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3543d6a877ea

Comment 11

[u421692]

Verified as fixed on Firefox 41 Beta 1