Closed Bug 1170913 Opened 4 years ago Closed 4 years ago

full-update target in tools/update-packaging/ always runs automation-partial-patch

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox39 verified, firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- verified
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(1 file)

The Makefile.in contains this at line 81:

full-update:: complete-patch $(if $(MOZ_AUTOMATION_UPDATE_PACKAGING),automation-partial-patch)

and automation-partial-patch is executed regardless of the value of MOZ_AUTOMATION_UPDATE_PACKAGING.
This was mshal's suggestion, and will need to land all the way up to beta.
Attachment #8614503 - Flags: review?(mh+mozilla)
Blocks: 1165405
Attachment #8614503 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/ef0428a8f2e3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Depends on: 1172318
Comment on attachment 8614503 [details] [diff] [review]
Use filter to look for MOZ_AUTOMATION_UPDATE_PACKAGING set to 1

Approval Request Comment
[Feature/regressing bug #]: Build config fix so that we can actually turn off nightly-style partial updates
[User impact if declined]: None, but this supports an IT project to move off hardware which will expire later this year
[Describe test coverage new/current, TreeHerder]: Bug 1172318 has fixed up the regression which was blowing up nightly l10n builds, so this is safe to go to Aurora.
[Risks and why]: Low risk, the aim is to disable nightly-style updates in the release automation, which are currently running by accident
[String/UUID change made/needed]: None

Lifting to beta is high enough, it won't be needed until beta has merged to release.
Attachment #8614503 - Flags: approval-mozilla-beta?
Attachment #8614503 - Flags: approval-mozilla-aurora?
Comment on attachment 8614503 [details] [diff] [review]
Use filter to look for MOZ_AUTOMATION_UPDATE_PACKAGING set to 1

Approved for uplift to aurora and beta.
Attachment #8614503 - Flags: approval-mozilla-beta?
Attachment #8614503 - Flags: approval-mozilla-beta+
Attachment #8614503 - Flags: approval-mozilla-aurora?
Attachment #8614503 - Flags: approval-mozilla-aurora+
Verified fix in 39.0b6 repack logs.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.