1172318 - No localized nightly builds of Firefox (from Jun 3) for most locales

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Francesco Lodolo [:flod]]

In bug 1169937 we didn't have any locales, now we have 3: ar, he, pl.

ftp://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/

Can we test any kind of fix and make sure that it actually solves the issue? We were able to get 1 build in 10 days.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Francesco Lodolo [:flod] (traveling, back 10 Jun) from comment #0)
> Can we test any kind of fix and make sure that it actually solves the issue?

The fix for bug 1169937 *did* actually solve the issue. Something *else* broke.

Comment 2

[Mike Hommey [:glandium]]

Relevant log:

05:37:47     INFO - Running post-upload command: post_upload.py -b mozilla-central-l10n -p firefox -i 20150606030209 --release-to-latest --release-to-dated
05:37:47     INFO - Upload complete
05:37:47     INFO - Return code: 0
05:37:47    FATAL - Uncaught exception: Traceback (most recent call last):
05:37:47    FATAL -   File "/builds/slave/m-cen-lx-l10n-ntly-1-000000000/scripts/mozharness/base/script.py", line 1315, in run
05:37:47    FATAL -     self.run_action(action)
05:37:47    FATAL -   File "/builds/slave/m-cen-lx-l10n-ntly-1-000000000/scripts/mozharness/base/script.py", line 1257, in run_action
05:37:47    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
05:37:47    FATAL -   File "/builds/slave/m-cen-lx-l10n-ntly-1-000000000/scripts/mozharness/base/script.py", line 1198, in _possibly_run_method
05:37:47    FATAL -     return getattr(self, method_name)()
05:37:47    FATAL -   File "scripts/scripts/desktop_l10n.py", line 881, in repack
05:37:47    FATAL -     self.summarize(self.repack_locale, self.query_locales())
05:37:47    FATAL -   File "scripts/scripts/desktop_l10n.py", line 480, in summarize
05:37:47    FATAL -     result = func(item)
05:37:47    FATAL -   File "scripts/scripts/desktop_l10n.py", line 840, in repack_locale
05:37:47    FATAL -     if self.make_upload(locale):
05:37:47    FATAL -   File "scripts/scripts/desktop_l10n.py", line 748, in make_upload
05:37:47    FATAL -     self.package_urls[locale]['partialMarUrl'])
05:37:47    FATAL - KeyError: 'partialMarUrl'
05:37:47    FATAL - Running post_fatal callback...
05:37:47    FATAL - Exiting -1

Comment 3

[Mike Hommey [:glandium]]

And the failing code was added in bug 1144703

Comment 4

[Mike Hommey [:glandium]]

So something must have changed that makes that key not set, whatever that is.

Comment 5

[Mike Hommey [:glandium]]

This is likely not a mozharness problem. I'll leave it to someone from releng to figure out what this is.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Looks like fallout from bug 1170913. The nightly and release repacks use files like
 http://hg.mozilla.org/mozilla-central/file/default/browser/config/mozconfigs/linux32/l10n-mozconfig
while we only want MOZ_AUTOMATION_UPDATE_PACKAGING set for the nightly case.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

In the en-US nightlies we set IS_NIGHTLY to yes in the env to leverage this block of code
 https://hg.mozilla.org/mozilla-central/file/default/build/unix/mozconfig.linux#l4
The l10n mozconfig sources that, but we don't have IS_NIGHTLY in the env.

But the desktop_l10n script appears to have it's own machinery for generating partials, so I need to figure out what's going on.

Working log:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/06/2015-06-03-03-02-08-mozilla-central-l10n/mozilla-central-linux-l10n-nightly-1-unknown-bm72-build1-build1.txt.gz

Busted log:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/06/2015-06-04-03-02-05-mozilla-central-l10n/mozilla-central-linux-l10n-nightly-1-unknown-bm74-build1-build1.txt.gz

Comment 8

[Chris AtLee [:catlee]]

I'm pretty sure we're relying on the in-tree logic for partials right now.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

The end of bug 1136750 is where that happened. mshal has been working on a patch for this.

Comment 10

[Michael Shal [:mshal]]

Attachment: nightly-l10n

This is the same as when we chatted on IRC - finally got a staging build to go through.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Michael, did you land the change? it would be nice to have the nightly back. Thanks!

Comment 13

[Axel Hecht [:Pike]]

Yes, he did, and mozharness.json was updated to include the change in today's nightly build.

I've just successfully updated my German mac nightly. Windows builds haven't started yet, Linux builds are in progress.

Comment 14

[Michael Shal [:mshal]]

Comment on attachment 8617061 [details] [diff] [review]
nightly-l10n

http://hg.mozilla.org/build/mozharness/rev/7ba09340e043
http://hg.mozilla.org/mozilla-central/rev/95afddf894e3

Comment 15

[Michael Shal [:mshal]]

I believe this is fixed. Please reopen if that's not the case.