Closed Bug 1171092 Opened 9 years ago Closed 9 years ago

[spark] Replace spark homescreen icons

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: amylee, Assigned: justindarc)

References

Details

Attachments

(6 files, 1 obsolete file)

Spark_Icons_pngs.zip
40.72 KB, application/zip
Details
bzlite pull-request (master)
45 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review
sharing pull-request (master)
39 bytes, text/x-github-pull-request
drs
: review+
Details | Review
directory pull-request (master)
41 bytes, text/x-github-pull-request
mikehenrty
: review+
Details | Review
studio pull-request (master)
38 bytes, text/x-github-pull-request
etienne
: review+
Details | Review
customizer-launcher pull-request (master)
50 bytes, text/x-github-pull-request
pdahiya
: review+
Details | Review
Attached file Spark_Icons_pngs.zip (obsolete) —
Please replace the current spark homescreen icons on Aries with the ones I've attached to this bug. Thanks!
Attached file Spark_Icons_pngs.zip —
Minor update to P2P Sharing icon
Attachment #8614781 - Attachment is obsolete: true
Depends on: 1171132
As far as I know, this doesn't actually involve the homescreen - changing category.
Component: Gaia::Homescreen → Gaia
Attachment #8615486 - Flags: review?(dale)
Attachment #8615488 - Flags: review?(drs)
Attachment #8615491 - Flags: review?(mhenretty)
Attachment #8615493 - Flags: review?(etienne)
Comment on attachment 8615502 [details] [review] customizer-launcher pull-request (master) Looks good and has my r+. See github for my comment on app name that should change 'Customizer L...' to 'Customizer' on home screen. Thanks!
Attachment #8615502 - Flags: review?(pdahiya) → review+
Comment on attachment 8615488 [details] [review] sharing pull-request (master) We have to replace this as well: https://github.com/fxos/sharing/blob/master/app/style/index.css#L17-L19
Attachment #8615488 - Flags: review?(drs) → review-
Comment on attachment 8615488 [details] [review] sharing pull-request (master) Oops. Let's try this again.
Attachment #8615488 - Flags: review- → review?(drs)
Comment on attachment 8615488 [details] [review] sharing pull-request (master) One last comment on the PR, then we're good to go.
Attachment #8615488 - Flags: review?(drs) → review+
Comment on attachment 8615493 [details] [review] studio pull-request (master) Studio part landed: https://github.com/fxos/studio/commit/723c5e00df17622657f68ddc2d0d6af9b4408c23
Attachment #8615493 - Flags: review?(etienne) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: