1171168 - Ensure correct string coercion in AVM1 TextField text and htmlText setters

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Till Schneidereit [:till]]

AVM1's alCoerceString uses AVM2's axCoerceString for non-objects. That returns `null` for `null` and `undefined` instead of `"null"` and `"undefined"`, respectively. I'm not sure that's correct: it seems likely to be a quirk that only affects AVM2.

Bug 1152155 has a SWF that's broken because of this: AVM1TextField#setText() coerces to string and assigns the result to the underlying AS3 TextField's text accessor. If AS code does something like `myTextField.text = undefined`, that causes an exception to be thrown because the value is converted to `null` instead of a string. In Flash, it causes the string "undefined" to be set.

I tried fixing this in [1], but now XMLDocument doesn't properly work anymore: `new XMLDocument()` causes the initial firstChild to have a textValue of `"undefined"`.

[1] https://github.com/tschneidereit/shumway/commit/6a382880154075f3abd3197a26f1ee9779d7fd42

Comment 1

[Till Schneidereit [:till]]

After discussing this with Yury, I'm morphing this bug to be about just the coercion for the TextField text and htmlText setters.

Comment 2

[Till Schneidereit [:till]]

Fixed in PR https://github.com/mozilla/shumway/pull/2271.