Closed Bug 1171254 Opened 5 years ago Closed 5 years ago

Use history.replaceState() to update the home panel state

Categories

(Firefox for iOS :: Browser, defect)

All
iOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bmunar)

References

Details

Attachments

(1 file)

PR
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
For bug 1148433, we first looked into setting the web view's URL to different fragment identifiers for each panel like we do on Fennec, but it was creating a new history entry each time. As a quick fix, we simply added an Int state onto each Browser to remember the panel. The WKWebView API for back/forward lists is pretty limited, so if we want to go with the fragment approach, we'll probably need to handle it in-content. history.replaceState() looks like a good option for doing this.
Status: NEW → ASSIGNED
Attached file PR
Attachment #8616103 - Flags: review?(bnicholson)
Comment on attachment 8616103 [details] [review]
PR

Overall approach is looking good! Lots of cleanup suggestions mentioned in the PR.
Attachment #8616103 - Flags: review?(bnicholson) → feedback+
Attachment #8616103 - Flags: review?(bnicholson)
Attachment #8616103 - Flags: review?(bnicholson)
Attachment #8616103 - Flags: review+
Attachment #8616103 - Flags: feedback+
https://github.com/mozilla/firefox-ios/commit/86ce518e335c0d2f2453b82a9c667c8993ab8e14
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.