1171463 - Regression: grey area shown where bottom toolbar used to be on about:home

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Aaron Train [:aaronmt]]

Open a new tab, see grey area at bottom where the toolbar used to be

Comment 1

[Aaron Train [:aaronmt]]

Have not seen this since filing.

Comment 2

[Aaron Train [:aaronmt]]

Scratch that, this still happens when you open a new tab from about:home

Comment 3

[Karim Benhmida [:karim]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/725

This is not quiet working yet.
I tried a few approaches, but none of them seemed to give the expected result:
- Creating an overlay view on top of the footer and showing it during the animation only (in the current commit)
- Removing (from the superview) / hiding the footer during the transition
- Removing the footer subviews during the transition

From what I understand, the grey area is the footer, and it shouldn't be displayed during the transition to a tab from the tabs tray.

To remove/hide views during the transition I used the transitionablePreShow and transitionableWillComplete delegate methods in BrowserViewController.

Correct me if I'm wrong, and if you're thinking about another approach please share. Thanks.

Comment 4

[Stephan Leroux [:sleroux]]

Hey Karim,

It looks like the problem is the TabTrayController is making the false assumption in making room for the footer to fade in and the BVC is blindly animating the footer in without knowing what it's about to show. I propose that:

1. In the BVC's transitionWillShow, run a check on the tabManager.selectedTab's URL to see if it's a home URL. If it is, ignore resetting the transform.

2. In the TabTrayController's showFullscreen method, factor in the fact we're showing an about:home screen into the frame calculation so we don't leave room for the toolbar if not needed. There's already a flag for this but it's only taking into consideration the size class since we don't want to show the toolbars for landscape/iPad animations.

Let me know if that helps.

Comment 5

[Brian Nicholson (:bnicholson)]

Removing NI since sleroux gave some good hints :)

Comment 6

[Stephan Leroux [:sleroux]]

Resolved as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1184233