1171490 - [Statusbar] Icons overlap rocketbar when minimized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Alberto Pastor [:albertopq]]

Attachment: screenicons.png

STR:

1.- Activate as many icons as you can
2.- Go to the browser and scroll

Expected:

The icons are shown by priority

Actual:

The icons overlap the rocketbar

Comment 1

[Alberto Pastor [:albertopq]]

Regression of bug 1168061

Comment 2

[Alberto Pastor [:albertopq]]

Actually, a combination of bug 1094759 and bug 1168061 regressed this. Investigating.

Comment 3

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30414/files

Tricky one... it seems that classList.toggle('maximized', undefined) won't work as we were expecting. The new bootstrap somehow is calling setAppearance twice (I'll investigate later) and the second call is adding the 'maximized' class again, although none of the conditions are true (undefined, actually).

The test I added fails in master. Scary :S

Alive, can you take a look? Thanks!

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8615408 [details]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30414/files

Cool, nice work!

Comment 6

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/174213026d911f98f4492ed3aac687cc78900238